Skip to content

Specifying the schemas for new APIs with OpenAPI#172285

Merged
e40pud merged 7 commits intoelastic:security/feature/alert-user-assignmentfrom
e40pud:security/feature/alert-user-assignment-open-api
Dec 1, 2023
Merged

Specifying the schemas for new APIs with OpenAPI#172285
e40pud merged 7 commits intoelastic:security/feature/alert-user-assignmentfrom
e40pud:security/feature/alert-user-assignment-open-api

Conversation

@e40pud
Copy link
Contributor

@e40pud e40pud commented Nov 30, 2023 •
edited
Loading

Summary

With these changes we specify the schemas for new alert assignments APIs with OpenAPI.

cc @yctercero @marshallmain

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Nov 30, 2023
@e40pud e40pud self-assigned this Nov 30, 2023
@e40pud e40pud requested review from a team as code owners November 30, 2023 13:45
@e40pud e40pud requested a review from vitaliidm November 30, 2023 13:45
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 30, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud mentioned this pull request Nov 30, 2023
Merged
17 tasks
yctercero
yctercero approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested update around naming, but otherwise LGTM! Don't want to block once change is in given different timezones. Thanks so much.

@kibana-ci
Copy link

kibana-ci commented Dec 1, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #4 / Agents fleet_upgrade_agent multiple agents should set a long expiration time when the start_time is set to now (immediate rollout period)
  • [job] [logs] FTR Configs #4 / Agents fleet_upgrade_agent multiple agents should set a long expiration time when the start_time is set to now (immediate rollout period)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.9MB 12.9MB -453.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud
Copy link
Contributor Author

e40pud commented Dec 1, 2023

Failed tests are skipped on main here #172337
Merging this one and will rebase feature branch to make sure tests are not failing there.

@e40pud e40pud merged commit 8a6b03f into elastic:security/feature/alert-user-assignment Dec 1, 2023
@e40pud e40pud deleted the security/feature/alert-user-assignment-open-api branch December 1, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yctercero yctercero yctercero approved these changes

@vitaliidm vitaliidm Awaiting requested review from vitaliidm vitaliidm was automatically assigned from elastic/security-detection-engine

Assignees

@e40pud e40pud

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@e40pud @elasticmachine @kibana-ci @yctercero