Skip to content

[ES|QL] Add support for * as valid function argument #172054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dej611 merged 9 commits into from
Nov 29, 2023
Merged

[ES|QL] Add support for * as valid function argument #172054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6dff3fd
:bug: Add support for star as function argument
dej611 Nov 28, 2023
801219e
:white_check_mark: Add tests
dej611 Nov 28, 2023
9c8d20d
:label: Type fix
dej611 Nov 28, 2023
4c6d826
:bug: Add validation on function arg with wildcard
dej611 Nov 28, 2023
0c49c41
:white_check_mark: Add more tests
dej611 Nov 28, 2023
496d5d1
Merge branch 'feature/esql-validation' into fix/esql-count-star
dej611 Nov 28, 2023
9eacb6b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Nov 28, 2023
cbc217b
Merge branch 'feature/esql-validation' into fix/esql-count-star
dej611 Nov 28, 2023
08ff613
Merge branch 'feature/esql-validation' into fix/esql-count-star
dej611 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/kbn-monaco/src/esql/antlr/esql_parser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,12 @@ operatorExpression
primaryExpression
: constant #constantDefault
| qualifiedName #dereference
| functionExpression #function
| LP booleanExpression RP #parenthesizedExpression
| identifier LP (booleanExpression (COMMA booleanExpression)*)? RP #functionExpression
;

functionExpression
: identifier LP (ASTERISK | (booleanExpression (COMMA booleanExpression)*))? RP
;

rowCommand
Expand Down
3 changes: 2 additions & 1 deletion packages/kbn-monaco/src/esql/antlr/esql_parser.interp
View file
Open in desktop

Large diffs are not rendered by default.

Loading