-
Notifications
You must be signed in to change notification settings - Fork 8.5k
WIP #172021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
WIP #172021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no longer present in EUI
- a lot of classNames that are passing either `eui-fullWidth` or `eui-displayBlock` can now be removed entirely with the wrapper gone - some classes with no corresponding CSS can be removed - other usages can be converted to `className`
…milarly named users" test
…single selection combo boxes
…to replace selected characters to fix behavior of recent selenium versions
…arValueWithKeyboard`
…rks in all browsers
…alternate option
…re combobox input is always empty before typing
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v90.0.0⏩v91.0.091.0.0EuiPopovers in dark mode to increase visibility & contrast against other page/panel backgrounds (#7310)EuiDataGridto prevent unneeded re-renders (#7324)roleprop toEuiAccordion(#7326)roleprop toEuiGlobalToastList(#7328)EuiSuperDatePickernow allows users to paste ISO 8601, RFC 2822, and Unix timestamps in theAbsolutetab input, in addition to timestamps in thedateFormatprop (#7331)EuiComboBoxes now behave more like a normal text field/input. Backspacing will no longer delete the entire value, and selected values can now be double clicked and copied. (#7332)EuiDataGrid's display settings popover now allows users to clear the "Lines per row" input before typing in a new number (#7338)EuiSuperDatePicker's Absolute tab for users manually typing in timestamps (#7341)EuiI18ns with multipletokensto accept dynamicvalues(#7341)Bug fixes
EuiComboBox'sonSearchChangecallback to pass the correcthasMatchingOptionsvalue (#7334)EuiSelectableTemplateSitewidebug where thepopoverButtonbehavior would break if passed a non-DOM React wrapper (#7339)Deprecations
EuiPopover: deprecatedanchorClassName. UseclassNameinstead (#7311)EuiPopover: deprecatedbuttonRef. UsepopoverRefinstead (#7311)EuiPopover: removed extra.euiPopover__anchordiv wrapper. Target.euiPopoverinstead if necessary (#7311)EuiButtonGroup'snameprop. This can safely be removed. (#7325)Breaking changes
euiPaletteComplimentary- useeuiPaletteComplementaryInstead (#7333)Accessibility
type="single"EuiButtonGroups to render standard buttons instead of radio buttons under the hood, per recent a11y recommendations (#7325)EuiAccordionnow defaults to a less screenreader-noisygrouprole instead ofregion. If your accordion contains significant enough content to be a document landmark role, you may re-configure it back toregion. (#7326)EuiDataGridcolumns via toolbar (#7327)EuiGlobalToastListnow defaults to alogrole. If your toasts will always require immediate user action, consider (with caution) using thealertrole instead. (#7328)CSS-in-JS conversions
$euiFontFamilyand$euiCodeFontFamilyto match Emotion fonts (#7332)