[Response Ops][Alerting] Remove echoed field value from bulk error responses when indexing alerts#172020
Merged
ymao1 merged 2 commits intoelastic:mainfrom Nov 28, 2023
Merged
Conversation
ymao1
added
Feature:Alerting
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2023
…sponses when indexing alerts (elastic#172020) ## Summary When alerts are bulk indexed in the rule registry and the alerts client, indexing errors may be returned where the entire field value that failed to be indexed is echoed in the reason. This can cause unnecessarily verbose logging so we want to sanitize the field value. (cherry picked from commit d9ebfd9)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2023
…rror responses when indexing alerts (#172020) (#172085) # Backport This will backport the following commits from `main` to `8.11`: - [[Response Ops][Alerting] Remove echoed field value from bulk error responses when indexing alerts (#172020)](#172020) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2023-11-28T16:25:03Z","message":"[Response Ops][Alerting] Remove echoed field value from bulk error responses when indexing alerts (#172020)\n\n## Summary\r\n\r\nWhen alerts are bulk indexed in the rule registry and the alerts client,\r\nindexing errors may be returned where the entire field value that failed\r\nto be indexed is echoed in the reason. This can cause unnecessarily\r\nverbose logging so we want to sanitize the field value.","sha":"d9ebfd9af1365bba54d5e1ac92f5e53f5fbebea8","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","backport:prev-minor","backport:prev-MAJOR","v8.12.0"],"number":172020,"url":"https://github.com/elastic/kibana/pull/172020","mergeCommit":{"message":"[Response Ops][Alerting] Remove echoed field value from bulk error responses when indexing alerts (#172020)\n\n## Summary\r\n\r\nWhen alerts are bulk indexed in the rule registry and the alerts client,\r\nindexing errors may be returned where the entire field value that failed\r\nto be indexed is echoed in the reason. This can cause unnecessarily\r\nverbose logging so we want to sanitize the field value.","sha":"d9ebfd9af1365bba54d5e1ac92f5e53f5fbebea8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172020","number":172020,"mergeCommit":{"message":"[Response Ops][Alerting] Remove echoed field value from bulk error responses when indexing alerts (#172020)\n\n## Summary\r\n\r\nWhen alerts are bulk indexed in the rule registry and the alerts client,\r\nindexing errors may be returned where the entire field value that failed\r\nto be indexed is echoed in the reason. This can cause unnecessarily\r\nverbose logging so we want to sanitize the field value.","sha":"d9ebfd9af1365bba54d5e1ac92f5e53f5fbebea8"}}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co>
Contributor
Author
|
Backport to 7.17 is unnecessary because alerts client did not exist in 7.17 and the error log inside the rule registry error handling was added in 8.0 in this PR: #120439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When alerts are bulk indexed in the rule registry and the alerts client, indexing errors may be returned where the entire field value that failed to be indexed is echoed in the reason. This can cause unnecessarily verbose logging so we want to sanitize the field value.