[Security Solution][API testing] Move and restructures Lists APIS#171992
Merged
WafaaNasr merged 20 commits intoelastic:mainfrom Nov 28, 2023
Merged
[Security Solution][API testing] Move and restructures Lists APIS#171992WafaaNasr merged 20 commits intoelastic:mainfrom
WafaaNasr merged 20 commits intoelastic:mainfrom
Conversation
…sr/kibana into move-structure-list-apis
…sr/kibana into move-structure-list-apis
…l we move the rule managment files to the new folder
…sr/kibana into move-structure-list-apis
pjhampton
approved these changes
Nov 28, 2023
Contributor
pjhampton
left a comment
There was a problem hiding this comment.
LGTM from SDA perspective ✅
nkhristinin
approved these changes
Nov 28, 2023
Contributor
nkhristinin
left a comment
There was a problem hiding this comment.
Review all code-owners file, I assume for EA and DE.
LGTM, thank you very much!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the initial work in this #166755
Addresses part of [Security Solution] Restructure API integration tests into meaningful groups that run in parallel on CI #151902 for List APIs tests
Added a new folder under the
security_solution_api_integrationcalledlists_and_exception_liststo hold the lists and exception lists tests, and split theListAPIs into two groups since the execution time in Serverless was close to 30 minsModified the x-pack/plugins/lists/common/schemas/response/exception_list_item_schema.mock.ts, x-pack/plugins/lists/common/schemas/response/exception_list_schema.mock.ts , x-pack/plugins/lists/common/schemas/response/list_item_schema.mock.ts, x-pack/plugins/lists/common/schemas/response/list_schema.mock.ts to accept
elastic userinput because it changes in ESS and ServerlessDeleted the
x-pack/test/lists_api_integrationfolderMoved the utility files associated with Basic tests to the new directory
security_solution_api_integration. Files not actively used in the previous folder were moved, while duplicate files remained in their original positions.Updated the below files imports from the old
lists_api_integrationfolder to the newlists_and_exception_listsUpdated the below files imports to the
ftr_provider_context_with_spaces.d.ts- risk_engine/risk_scoring_task/task_execution_nondefault_spaces.tsThe QA phase concluded with all tests passing successfully. 🟢
Updated the CodeOwner file for the newly moved tests
Add a new util file to
deleteAllExceptionsunder the olddetection_engine_apifolder since the Rule management related-tests are still need to be moved over to the new folderOld/new group details, decisions, and execution time are mentioned in this document