Skip to content

[Custom threshold] Fix not showing threshold line in lens preview#171970

Merged
maryam-saeidi merged 1 commit intoelastic:mainfrom
maryam-saeidi:171843-fix-not-showing-threshold-line
Nov 27, 2023
Merged

[Custom threshold] Fix not showing threshold line in lens preview#171970
maryam-saeidi merged 1 commit intoelastic:mainfrom
maryam-saeidi:171843-fix-not-showing-threshold-line

Conversation

@maryam-saeidi
Copy link
Member

Closes #171843

Summary

This PR fixes not showing the threshold line in the following case:

@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Feature: Custom threshold Observability custom threshold rule type labels Nov 27, 2023
@maryam-saeidi maryam-saeidi self-assigned this Nov 27, 2023
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner November 27, 2023 11:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@ghost
Copy link

ghost commented Nov 27, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi enabled auto-merge (squash) November 27, 2023 11:51
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / management advanced settings feature controls settings can be saved with the advancedSettings: ["all"] feature privilege

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 0942bce into elastic:main Nov 27, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This PR does not require backporting labels Nov 27, 2023
@maryam-saeidi maryam-saeidi deleted the 171843-fix-not-showing-threshold-line branch November 27, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature: Custom threshold Observability custom threshold rule type release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Custom threshold] Threshold line is sometimes not visible in preview chart

5 participants