[ML] Validates and limits threading parameters for starting model deployment#171921
Merged
darnautov merged 4 commits intoelastic:mainfrom Nov 27, 2023
Merged
Conversation
darnautov
added
release_note:enhancement
:ml
Feature:3rd Party Models
Contributor
|
Pinging @elastic/ml-ui (:ml) |
droberts195
reviewed
Nov 24, 2023
x-pack/plugins/ml/public/application/model_management/deployment_setup.tsx
Outdated
Show resolved
Hide resolved
| isInvalid={!!errors.numOfAllocations} | ||
| fullWidth | ||
| min={1} | ||
| max={totalMlProcessors} |
There was a problem hiding this comment.
Does undefined mean "no max" here?
…nt_setup.tsx Co-authored-by: David Roberts <dave.roberts@elastic.co>
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @darnautov |
peteharverson
approved these changes
Nov 27, 2023
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested locally and LGTM
szabosteve
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #171883
This PR adds:
max_single_ml_node_processorslimittotal_ml_processorsfieldChecklist