[ES|QL] Allows searching in the documentation description#171916
Merged
stratoula merged 5 commits intoelastic:mainfrom Nov 27, 2023
Merged
[ES|QL] Allows searching in the documentation description#171916stratoula merged 5 commits intoelastic:mainfrom
stratoula merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
|
👍🏻 This is great @stratoula - This is going to be super helpful. |
dej611
approved these changes
Nov 27, 2023
Contributor
dej611
left a comment
There was a problem hiding this comment.
Tested locally with Safari and all good 👍
Let few minor code comments, but will no block it.
packages/kbn-language-documentation-popover/src/components/documentation_content.tsx
Show resolved
Hide resolved
packages/kbn-language-documentation-popover/src/utils/element_to_string.ts
Outdated
Show resolved
Hide resolved
packages/kbn-language-documentation-popover/src/utils/element_to_string.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows searching on the ES|QL reference markdown. This means that now the search will return more results. Examples:
Note: I am not allowing this for Lens formulas. I introduced a new property to disable it. The implementation works for formulas too but we haven't received any negative feedback so far so I would like to test it in the ES|QL reference first.
Checklist