Skip to content

[ES|QL] Allows searching in the documentation description#171916

Merged
stratoula merged 5 commits intoelastic:mainfrom
stratoula:esql-more-powerful-search
Nov 27, 2023
Merged

[ES|QL] Allows searching in the documentation description#171916
stratoula merged 5 commits intoelastic:mainfrom
stratoula:esql-more-powerful-search

Conversation

@stratoula
Copy link
Contributor

Summary

Allows searching on the ES|QL reference markdown. This means that now the search will return more results. Examples:

  • If I search for keep it will return all the occurences of the word keep so the user will see the keep command but also all the other commands that the keep word is used in the examples. I think that this is very useful as the user can see more than 1 examples of a command
  • If I search for date it will return not only the commands that have the word date but also the commands that allow date in their arguments
  • As now it searches also to the description it can also return false positive results. I think is an accepted drawback.
image

Note: I am not allowing this for Lens formulas. I introduced a new property to disable it. The implementation works for formulas too but we haven't received any negative feedback so far so I would like to test it in the ES|QL reference first.

Checklist

@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:ES|QL ES|QL related features in Kibana release_note:enhancement v8.12.0 backport:skip This PR does not require backporting and removed enhancement New value added to drive a business result labels Nov 24, 2023
@stratoula stratoula marked this pull request as ready for review November 24, 2023 12:41
@stratoula stratoula requested a review from a team as a code owner November 24, 2023 12:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@ninoslavmiskovic
Copy link
Contributor

👍🏻 This is great @stratoula - This is going to be super helpful.

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with Safari and all good 👍

Let few minor code comments, but will no block it.

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1141 1142 +1
securitySolution 4727 4728 +1
stackAlerts 120 121 +1
textBasedLanguages 48 49 +1
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +477.0B
textBasedLanguages 150.5KB 151.0KB +518.0B
total +995.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 037f688 into elastic:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants