[Dashboard Navigation] Add Links telemetry#171877
Merged
Heenawter merged 7 commits intoelastic:mainfrom Nov 27, 2023
Merged
Conversation
Heenawter
added
Team:Presentation
Heenawter
commented
Nov 23, 2023
| * Dashboard-to-dashboard navigation | ||
| */ | ||
| const { loading: loadingOnClickProps, value: onClickProps } = useAsync(async () => { | ||
| const onClickProps = useMemo(() => { |
Contributor
Author
There was a problem hiding this comment.
This was accidentally left async in #167928 when it should have been removed.
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @Heenawter |
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
pgayvallet
approved these changes
Nov 24, 2023
nickpeihl
approved these changes
Nov 27, 2023
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm!
code review and tested usage collection using this script. Dashboard and external links both report clicks.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164305
Summary
This PR adds two
uiCountersto keep track of when something is clicked in the new Links panel:dashboardLink:click- counts when a dashboard link is clickedexternalLink:click- counts when an external link is clickedThese counters can be tracked via the
kibana-ui-countersdata view on the telemetry clusters, like so:Note that this only applies if the
onClickmethod is called; if the user, for example, right clicks on the link and selects "Open in new tab" instead, this "click" will not be tracked. To my knowledge, there is no way to track these types of clicks.For maintainers