Skip to content

[ES|QL] Displays the columns as they are returned from the query #171874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 2 commits into from
Nov 27, 2023
Merged

[ES|QL] Displays the columns as they are returned from the query #171874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15abd9a
[ES|QL] Removes the sanitize function from the strategy
stratoula Nov 23, 2023
667640f
Merge branch 'main' into fix-esql-strategy
stratoula Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/plugins/data/common/search/expressions/esql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ function normalizeType(type: string): DatatableColumnType {
}
}

function sanitize(value: string) {
return value.replace(/[\(\)]/g, '_');
}

function extractTypeAndReason(attributes: any): { type?: string; reason?: string } {
if (['type', 'reason'].every((prop) => prop in attributes)) {
return attributes;
Expand Down Expand Up @@ -249,8 +245,8 @@ export const getEsqlFn = ({ getStartDependencies }: EsqlFnArguments) => {
map(({ rawResponse: body, warning }) => {
const columns =
body.columns?.map(({ name, type }) => ({
id: sanitize(name),
name: sanitize(name),
id: name,
name,
meta: { type: normalizeType(type) },
})) ?? [];
const columnNames = columns.map(({ name }) => name);
Expand Down