[Security Solution] Specific Cypress executions for Rule Management team#171868
Conversation
Rule Management team
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
delanni
left a comment
There was a problem hiding this comment.
new test suite additions from the ops perspective 👍
Keep in mind, the current test slice runs on these suites are quite fast (8-12 minutes). Since several other tests are running for ~30 minutes, it could be OK to reduce parallelism, and have fewer, but longer running slices (this would reduce the sum overhead from agent provisioning/bootstrap)
|
@MadameSheema Looking into it |
banderror
left a comment
There was a problem hiding this comment.
Everything LGTM, it's just some paths need to be fixed in x-pack/test/security_solution_cypress/package.json.
I also posted a nit comment about folder structure, but it shouldn't block the PR.
There was a problem hiding this comment.
Nit: Hey @MadameSheema, was it necessary to move rule management tests outside of the x-pack/test/security_solution_cypress/cypress/e2e/detection_response folder to x-pack/test/security_solution_cypress/cypress/e2e/rule_management? Can we move them back?
I'd prefer having the following structure:
x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_enginex-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management
cc @yctercero
There was a problem hiding this comment.
++ on suggested change. I'm somewhat hesitant to base folder structure on teams (as we've updated teams several times), but I think it's needed in order to group the configs, right?
There was a problem hiding this comment.
@yctercero is around making it easier to maintain the scripts we use as well as checking as knowing by a quick look who is the owner. Another thing that I noticed when we didn't have this structure is that several tests didn't have ownership at all making hard to follow some automated flows on operations side.
Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
banderror
left a comment
There was a problem hiding this comment.
LGTM, thanks @MadameSheema 👍
|
@MadameSheema I added the |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
This was reverted with 177dbd1 due to a parse error in on_merge.yml. See https://buildkite.com/elastic/kibana-on-merge/builds/38581#018c1627-73c5-4f15-9c17-f45b82626364. |
…agement` team (elastic#171868)" This reverts commit 242cb6f.
Addresses: #153661
Summary
This PR is part of the effort we are making to have our cypres serverless tests ready for the second quality gate (QA environment - real serverless project and also part of the initial effort started by #153664.
With the introduced changes, we are creating specific Rule Management Cypress executions for both ESS and serverless with the aim of:
In this PR:
rule_managementteam