[Lens][Unified search] Auto expand comboboxes and popovers based on the content by mbondyra · Pull Request #171573 · elastic/kibana

mbondyra · 2023-11-20T18:21:40Z

Summary

Fixes partially two remaining tasks from #168753
Fixes partially dataview issue from #170398
It stretches to maximum approximate 60 characters if any of the labels in the list is of this length. If the content doesn't need the container to stretch, it doesn't do it.

Field picker in Lens

minimum width:

auto-expanded width:

Layer data view picker in Lens

Data view picker in Unified Search

Data view picker in dashboard Create control flyout

Unified search data view select component (tested in maps)

Unified search field and value picker

Adds `panelMinWidth`, removes the custom flex width change behavior

Nov-22-2023.14-20-48.mp4

Discover breakdown field

Removes the focus stretching and instead uses the panelMinWidth prop

…fix'

ThomThomson

Changes in presentation-util LGTM! Nice work!

…fix'

…ana into widen_eui_selectables_steps

…-fix'

davismcphee

Tested the Unified Histogram changes locally, and it's working as intended. Data Discovery changes LGTM 👍

elasticmachine · 2023-11-22T09:38:33Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

…ana into widen_eui_selectables_steps

…i_selectables_steps

…ana into widen_eui_selectables_steps

dej611 · 2023-11-23T14:38:30Z

src/plugins/unified_search/public/filters_builder/filter_item/field_input.tsx

-    });
  };

-  const handleFocus: React.FocusEventHandler<HTMLDivElement> = () => {


That's nice to get rid of this type of code 🎉

dej611

First code review pass done.
Will test it locally shortly.

packages/kbn-calculate-width-from-char-count/src/calculate_width_from_char_count.ts

…i_selectables_steps # Conflicts: # x-pack/plugins/lens/tsconfig.json

This reverts commit feff1c7.

…i_selectables_steps

mbondyra · 2023-11-27T11:47:43Z

Thanks @dej611 I addressed your comments 😊

dej611

Tested locally with Safari! 👍

kibana-ci · 2023-11-28T12:12:55Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`eventAnnotationListing`	456	460	+4
`lens`	1141	1145	+4
`presentationUtil`	124	128	+4
`unifiedHistogram`	64	68	+4
`unifiedSearch`	215	219	+4
total			+20

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/calculate-width-from-char-count`	-	7	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`eventAnnotationListing`	196.8KB	197.0KB	+132.0B
`lens`	1.4MB	1.4MB	+476.0B
`presentationUtil`	82.0KB	82.4KB	+402.0B
`unifiedHistogram`	50.6KB	51.0KB	+409.0B
`unifiedSearch`	213.8KB	214.7KB	+907.0B
total			+2.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/calculate-width-from-char-count`	-	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`unifiedSearch`	35.3KB	35.4KB	+64.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/calculate-width-from-char-count`	-	7	+7

async chunk count

id	before	after	diff
`unifiedSearch`	20	21	+1

History

💚 Build #178838 succeeded 13e98f8
💔 Build #178791 failed f6c3d64
💚 Build #178758 succeeded b880b58
💚 Build #178450 succeeded 8642e05
💚 Build #178308 succeeded 6825bb0
💛 Build #178239 was flaky 0ed2882

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mbondyra added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens Feature:Unified search Unified search related tasks v8.12.0 labels Nov 20, 2023

mbondyra force-pushed the widen_eui_selectables_steps branch 2 times, most recently from bc2a5b8 to 73acf81 Compare November 20, 2023 20:14

mbondyra and others added 4 commits November 21, 2023 15:32

widen all the things

8f31868

moving to unfied search

d813f82

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

bb964e2

…fix'

fix type

d8670fb

mbondyra force-pushed the widen_eui_selectables_steps branch 2 times, most recently from 00f0e43 to b076dd1 Compare November 21, 2023 14:41

move to package

2a7a0b7

mbondyra force-pushed the widen_eui_selectables_steps branch from b076dd1 to 2a7a0b7 Compare November 21, 2023 14:53

remove package from unified search

f628e1f

mbondyra force-pushed the widen_eui_selectables_steps branch from 512d3af to f628e1f Compare November 21, 2023 15:21

mbondyra marked this pull request as ready for review November 21, 2023 15:29

mbondyra requested review from a team as code owners November 21, 2023 15:29

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

dbbe762

ThomThomson approved these changes Nov 21, 2023

View reviewed changes

discover changes

86e4e91

mbondyra requested a review from a team as a code owner November 21, 2023 15:50

kibanamachine and others added 4 commits November 21, 2023 15:57

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

642c672

…fix'

trigger CI

4c2bf9a

Merge branch 'widen_eui_selectables_steps' of github.com:mbondyra/kib…

aeb1af5

…ana into widen_eui_selectables_steps

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

a9e440b

…-fix'

davismcphee approved these changes Nov 21, 2023

View reviewed changes

mbondyra added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Nov 22, 2023

mbondyra and others added 6 commits November 22, 2023 10:38

Merge branch 'main' into widen_eui_selectables_steps

c31ea17

fix test

a2fd59a

Merge branch 'widen_eui_selectables_steps' of github.com:mbondyra/kib…

29694b8

…ana into widen_eui_selectables_steps

fix test

4177e2e

Merge commit 'edc1b47bbda889dbbebc612f89e90e3505d171ad' into widen_eu…

1c90e9c

…i_selectables_steps

removing the flex width changing behavior from unified search

9005945

mbondyra mentioned this pull request Nov 22, 2023

[Unified Search] Improve accessibility of flex width comboboxes #171439

Closed

4 tasks

mbondyra changed the title ~~[Lens][Unified search] Auto expand dataview popovers based on the content~~ [Lens][Unified search] Auto expand comboboxes and popovers based on the content Nov 22, 2023

mbondyra and others added 4 commits November 22, 2023 21:50

Merge branch 'main' into widen_eui_selectables_steps

0ed2882

Merge commit '17ed0748e8d7671df31291d7b2bce5460c74b0f5' into widen_eu…

3902e4a

…i_selectables_steps

Merge branch 'widen_eui_selectables_steps' of github.com:mbondyra/kib…

6825bb0

…ana into widen_eui_selectables_steps

attach to right

8642e05

dej611 reviewed Nov 23, 2023

View reviewed changes

packages/kbn-calculate-width-from-char-count/src/calculate_width_from_char_count.ts Show resolved Hide resolved

mbondyra added 5 commits November 24, 2023 12:17

add calculateWidthFromEntries

b880b58

make types smarter

feff1c7

Merge commit 'f555dbef294516517d89e9d41e14b1b2a55425dd' into widen_eu…

f6c3d64

…i_selectables_steps # Conflicts: # x-pack/plugins/lens/tsconfig.json

Revert "make types smarter"

13e98f8

This reverts commit feff1c7.

Merge commit 'a8dc2292c6f967b496611829d39c1bd769984577' into widen_eu…

2f58688

…i_selectables_steps

dej611 approved these changes Nov 28, 2023

View reviewed changes

revert css

4dbc679

mbondyra removed the request for review from a team November 28, 2023 11:14

mbondyra merged commit 085878c into elastic:main Nov 28, 2023

kibanamachine added the backport:skip This PR does not require backporting label Nov 28, 2023

mbondyra deleted the widen_eui_selectables_steps branch November 28, 2023 12:13

spong mentioned this pull request Dec 13, 2023

[Security Solution] Rule tags popover hides tags of prebuilt rules #173151

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens][Unified search] Auto expand comboboxes and popovers based on the content#171573

[Lens][Unified search] Auto expand comboboxes and popovers based on the content#171573
mbondyra merged 28 commits intoelastic:mainfrom
mbondyra:widen_eui_selectables_steps

mbondyra commented Nov 20, 2023 •

edited

Loading

Uh oh!

ThomThomson left a comment

Uh oh!

davismcphee left a comment

Uh oh!

elasticmachine commented Nov 22, 2023

Uh oh!

dej611 Nov 23, 2023

Uh oh!

dej611 left a comment

Uh oh!

Uh oh!

mbondyra commented Nov 27, 2023

Uh oh!

dej611 left a comment

Uh oh!

kibana-ci commented Nov 28, 2023

API count

async chunk count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mbondyra commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 22, 2023

Uh oh!

dej611 Nov 23, 2023

Choose a reason for hiding this comment

Uh oh!

dej611 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mbondyra commented Nov 27, 2023

Uh oh!

dej611 left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Nov 28, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mbondyra commented Nov 20, 2023 •

edited

Loading