[Security Solution][API testing] Move and restructures Basic detection engine tests#171531
Merged
WafaaNasr merged 18 commits intoelastic:mainfrom Nov 23, 2023
Merged
Conversation
WafaaNasr
added
release_note:skip
…ructure-basic-detection_engine
…ructure-basic-detection_engine
…ructure-basic-detection_engine
3 tasks
…b.com/WafaaNasr/kibana into move-structure-basic-detection_engine
…ructure-basic-detection_engine:wq
yctercero
reviewed
Nov 22, 2023
| const dataPathBuilder = new EsArchivePathBuilder(isServerless); | ||
| const auditbeatPath = dataPathBuilder.getPath('auditbeat/hosts'); | ||
|
|
||
| describe('create_ml_rules', () => { |
Contributor
There was a problem hiding this comment.
Is it ok to not have a tag at the parent level?
Contributor
Author
There was a problem hiding this comment.
Yes, in this test suite (parent level) specifically we don't share the test methods in both envs instead we test the differences among both, so it wouldn't make sense to add the tag on the top level, and Mocha already pick up the tags at any level (the suite & the test method)
yctercero
approved these changes
Nov 22, 2023
Contributor
yctercero
left a comment
yctercero
left a comment
There was a problem hiding this comment.
LGTM! Just one comment to ensure the test gets picked up if a tag is missing at the top describe block for one of the tests.
mistic
approved these changes
Nov 23, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the initial work in this #166755
BasicEss tests and theEssentialsServerless tests, is calledbasic_essentials_licenseserverless/config.base.essentialsandess/config.base.basicsecurity_solution_api_integration. Files not actively used in the previous folder were moved, while duplicate files remained in their original positions.