[Security Solution][API testing] Move and restructures Privileges related tests and Action Throttle#171397
Merged
WafaaNasr merged 3 commits intoelastic:mainfrom Nov 16, 2023
Conversation
WafaaNasr
added
release_note:skip
nkhristinin
approved these changes
Nov 16, 2023
Contributor
nkhristinin
left a comment
nkhristinin
left a comment
There was a problem hiding this comment.
LGTM!
Have one question, but it's not blokker! Thank you!
| } = await supertest.get(`/api/alerting/rule/${rule.id}`); | ||
| } = await supertest | ||
| .get(`/api/alerting/rule/${rule.id}`) | ||
| .set(X_ELASTIC_INTERNAL_ORIGIN_REQUEST, 'kibana'); |
Contributor
There was a problem hiding this comment.
Just curious if we really need here this header, my understanding was that it's needed only for internal requests
Contributor
Author
There was a problem hiding this comment.
That's correct since the notify_when property is internal we need this header to access it!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the initial work in this #166755
security_solution_api_integration. Files not actively used in the previous folder were moved, while duplicate files remained in their original positions.