-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Dashboard] Add Dashboard title to browser tab title #171255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Heenawter
merged 7 commits into
elastic:main
from
Heenawter:fix-dashboard-tab-title_2023-11-14
Nov 16, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0b79511
Change tab title
Heenawter 7067301
Add tests for browser tab title
Heenawter 401ff96
Remove `.only`
Heenawter dc9e299
Rename `docTitle` to make it more descriptive
Heenawter 0383cb2
Default to "New Dashboard"
Heenawter fba6e32
Move tab title logic to new component
Heenawter 21ff2b8
Re-add comment
Heenawter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/plugins/dashboard/public/dashboard_app/tab_title_setter/dashboard_tab_title_setter.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { useEffect } from 'react'; | ||
|
|
||
| import { ViewMode } from '@kbn/embeddable-plugin/common'; | ||
|
|
||
| import { pluginServices } from '../../services/plugin_services'; | ||
| import { DashboardAPI } from '../..'; | ||
| import { getDashboardTitle } from '../_dashboard_app_strings'; | ||
|
|
||
| export const DashboardTabTitleSetter = ({ | ||
| dashboardContainer, | ||
| }: { | ||
| dashboardContainer: DashboardAPI; | ||
| }) => { | ||
| const { | ||
| chrome: { docTitle: chromeDocTitle }, | ||
| } = pluginServices.getServices(); | ||
| const title = dashboardContainer.select((state) => state.explicitInput.title); | ||
| const lastSavedId = dashboardContainer.select((state) => state.componentState.lastSavedId); | ||
|
|
||
| /** | ||
| * Set chrome tab title when dashboard's title changes | ||
| */ | ||
| useEffect(() => { | ||
| /** We do not want the tab title to include the "Editing" prefix, so always send in view mode */ | ||
| chromeDocTitle.change(getDashboardTitle(title, ViewMode.VIEW, !lastSavedId)); | ||
| }, [title, chromeDocTitle, lastSavedId]); | ||
|
|
||
| return null; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.