Skip to content

[ftr] split alerting api-integration group2#171105

Merged
dmlemeshko merged 6 commits intoelastic:mainfrom
dmlemeshko:ftr/split-alerting-api-group-2
Nov 16, 2023
Merged

[ftr] split alerting api-integration group2#171105
dmlemeshko merged 6 commits intoelastic:mainfrom
dmlemeshko:ftr/split-alerting-api-group-2

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Nov 13, 2023

Summary

Splitting some of the long running Alerting FTR configs:

Config Path Runtime
x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts 36m 55s
x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts 36m 58s
image

After split:

Config Path Runtime
x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts 22m 59s
x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts 23m 15s
x-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts 22m 26s
x-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts 21m 36s

@dmlemeshko dmlemeshko force-pushed the ftr/split-alerting-api-group-2 branch from 54b38af to 4a9f0f0 Compare November 13, 2023 15:22
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes FTR v8.12.0 v8.11.1 v8.10.5 labels Nov 14, 2023
@dmlemeshko dmlemeshko marked this pull request as ready for review November 14, 2023 09:36
@dmlemeshko dmlemeshko requested review from a team as code owners November 14, 2023 09:36
@dmlemeshko dmlemeshko changed the title [ftr] split test configs [ftr] split alerting api-integration group2 Nov 14, 2023
@dmlemeshko dmlemeshko enabled auto-merge (squash) November 14, 2023 15:06
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const retry = getService('retry');

describe('getRuleExecutionKpi', () => {
// failing on CI, this file wasn't loaded in any config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierM looked at some blames, seems like this one was specifically not run for a while, but the "global" version got enabled at some point. Maybe add a comment to the file if we know we're not using it at the moment? Or maybe it was mistakenly not enabled?

@dmlemeshko dmlemeshko merged commit 44fa330 into elastic:main Nov 16, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.10:
- [RAM] Fix Snooze And Unsnooze Tests (#163632)
8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 171105

Questions ?

Please refer to the Backport tool documentation

@dmlemeshko
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Nov 17, 2023
## Summary

Splitting some of the long running Alerting FTR configs:

| Config Path | Runtime |
| ------------- | ------------- |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts
| 36m 55s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts
| 36m 58s |

<img width="1576" alt="image"
src="https://github.com/elastic/kibana/assets/10977896/c73374c6-d769-4536-a277-5a2a38b83fa4">

After split:

| Config Path | Runtime |
| ------------- | ------------- |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts
| 22m 59s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts
| 23m 15s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts
| 22m 26s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts
| 21m 36s |

(cherry picked from commit 44fa330)

# Conflicts:
#	.buildkite/ftr_configs.yml
@dmlemeshko
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Nov 17, 2023
## Summary

Splitting some of the long running Alerting FTR configs:

| Config Path | Runtime |
| ------------- | ------------- |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts
| 36m 55s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts
| 36m 58s |

<img width="1576" alt="image"
src="https://github.com/elastic/kibana/assets/10977896/c73374c6-d769-4536-a277-5a2a38b83fa4">

After split:

| Config Path | Runtime |
| ------------- | ------------- |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts
| 22m 59s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts
| 23m 15s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts
| 22m 26s |
|
x-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts
| 21m 36s |

(cherry picked from commit 44fa330)

# Conflicts:
#	.buildkite/ftr_configs.yml
#	x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/alerting/index.ts
mattkime pushed a commit to mattkime/kibana that referenced this pull request Nov 20, 2023
…lastic#171468)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[ftr] split alerting api-integration group2
(elastic#171105)](elastic#171105)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-11-16T22:59:35Z","message":"[ftr]
split alerting api-integration group2 (elastic#171105)\n\n##
Summary\r\n\r\nSplitting some of the long running Alerting FTR
configs:\r\n\r\n| Config Path | Runtime |\r\n| ------------- |
-------------
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts\r\n|
36m 55s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts\r\n|
36m 58s |\r\n\r\n<img width=\"1576\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/10977896/c73374c6-d769-4536-a277-5a2a38b83fa4\">\r\n\r\nAfter
split:\r\n\r\n| Config Path | Runtime |\r\n| ------------- |
-------------
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts\r\n|
22m 59s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts\r\n|
23m 15s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts\r\n|
22m 26s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts\r\n|
21m 36s
|","sha":"44fa330086eee20e462296845650ea111d8b76fc","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","FTR","v8.12.0","v8.11.1","v8.10.5"],"number":171105,"url":"https://github.com/elastic/kibana/pull/171105","mergeCommit":{"message":"[ftr]
split alerting api-integration group2 (elastic#171105)\n\n##
Summary\r\n\r\nSplitting some of the long running Alerting FTR
configs:\r\n\r\n| Config Path | Runtime |\r\n| ------------- |
-------------
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts\r\n|
36m 55s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts\r\n|
36m 58s |\r\n\r\n<img width=\"1576\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/10977896/c73374c6-d769-4536-a277-5a2a38b83fa4\">\r\n\r\nAfter
split:\r\n\r\n| Config Path | Runtime |\r\n| ------------- |
-------------
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts\r\n|
22m 59s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts\r\n|
23m 15s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts\r\n|
22m 26s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts\r\n|
21m 36s
|","sha":"44fa330086eee20e462296845650ea111d8b76fc"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171105","number":171105,"mergeCommit":{"message":"[ftr]
split alerting api-integration group2 (elastic#171105)\n\n##
Summary\r\n\r\nSplitting some of the long running Alerting FTR
configs:\r\n\r\n| Config Path | Runtime |\r\n| ------------- |
-------------
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts\r\n|
36m 55s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts\r\n|
36m 58s |\r\n\r\n<img width=\"1576\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/10977896/c73374c6-d769-4536-a277-5a2a38b83fa4\">\r\n\r\nAfter
split:\r\n\r\n| Config Path | Runtime |\r\n| ------------- |
-------------
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config.ts\r\n|
22m 59s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts\r\n|
23m 15s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group4/config.ts\r\n|
22m 26s
|\r\n|\r\nx-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts\r\n|
21m 36s
|","sha":"44fa330086eee20e462296845650ea111d8b76fc"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dmlemeshko dmlemeshko deleted the ftr/split-alerting-api-group-2 branch November 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FTR release_note:skip Skip the PR/issue when compiling release notes v8.11.1 v8.11.2 v8.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants