Skip to content

fix: incorrect import causes storybook build to fail#171033

Merged
mistic merged 2 commits intoelastic:mainfrom
delanni:fix-storybook-emotion-error
Nov 10, 2023
Merged

fix: incorrect import causes storybook build to fail#171033
mistic merged 2 commits intoelastic:mainfrom
delanni:fix-storybook-emotion-error

Conversation

@delanni
Copy link
Copy Markdown
Contributor

@delanni delanni commented Nov 10, 2023

Summary

This change in this PR: #167998 is causing an error in building storybooks: https://buildkite.com/elastic/kibana-on-merge/builds/38046#018bb9d2-7820-43ad-9144-e40d33d28c3b

In brief, the import looks like this:

import { css } from '@emotion/react/dist/emotion-react.cjs';

but it should be like this:

import { css } from '@emotion/react';

It looks it's a bad import, we should set up a pre-merge check for these accidental auto-imports.

cc: @darnautov please review

@delanni delanni requested a review from a team as a code owner November 10, 2023 15:59
@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting ci:build-storybooks labels Nov 10, 2023
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1854 1846 -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB -7.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 33757f6 into elastic:main Nov 10, 2023
@mistic mistic added v8.12.0 Team:Operations Kibana-Operations Team labels Nov 10, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni delanni deleted the fix-storybook-emotion-error branch November 11, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:build-storybooks release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants