Skip to content

[Security][Quality Gate] EDR Workflows Integration#171021

Closed
dkirchan wants to merge 20 commits intomainfrom
security/EDR-integration
Closed

[Security][Quality Gate] EDR Workflows Integration#171021
dkirchan wants to merge 20 commits intomainfrom
security/EDR-integration

Conversation

@dkirchan
Copy link
Copy Markdown
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ghost
Copy link
Copy Markdown

ghost commented Nov 10, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dkirchan dkirchan changed the title Security/edr integration [Security][Quality Gate] EDR Workflows Integration Nov 10, 2023
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +6.4KB
securitySolutionServerless 330.6KB 336.9KB +6.3KB
total +12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.7KB 41.7KB -1.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 468 469 +1

Total ESLint disabled count

id before after diff
securitySolution 538 539 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dkirchan
Copy link
Copy Markdown
Contributor Author

@szwarckonrad @paul-tavares I am closing this Draft PR as done/covered by the [MKI][EDR Workflows] Enable MKI on EDR Workflows Cypress tests

@dkirchan dkirchan closed this Apr 29, 2024
@dkirchan dkirchan deleted the security/EDR-integration branch May 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants