Upgrade EUI to v91.0.0 (with backports) #170716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkajtoch
added
release_note:skip
tkajtoch
force-pushed
the
eui-v91.x
branch
15 times, most recently
from
8a7a7d9 to
0e3ea13
Compare
cee-chen
added a commit
to cee-chen/kibana
that referenced
this pull request
Nov 16, 2023
- can be reverted once elastic#170716 merges
tkajtoch
force-pushed
the
eui-v91.x
branch
2 times, most recently
from
2c67880 to
977a4b4
Compare
4 tasks
tkajtoch
force-pushed
the
eui-v91.x
branch
3 times, most recently
from
3876821 to
53e6a31
Compare
peteharverson
approved these changes
Dec 13, 2023
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Changes to ML tests LGTM (code review only).
azasypkin
approved these changes
Dec 13, 2023
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
Changes in Security/Spaces tests LGTM.
sebelga
approved these changes
Dec 13, 2023
pheyos
approved these changes
Dec 13, 2023
Member
pheyos
left a comment
pheyos
left a comment
There was a problem hiding this comment.
web_element_wrapper test service change LGTM
Heenawter
approved these changes
Dec 13, 2023
Contributor
Heenawter
left a comment
Heenawter
left a comment
There was a problem hiding this comment.
Tested to ensure that the removal of anchorClassName didn't impact anything visually + looked over test changes. LGTM 👍
botelastic
bot
added
the
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
justinkambic
approved these changes
Dec 13, 2023
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Code LGTM, no smoke testing on my end
yuliacech
approved these changes
Dec 14, 2023
vitaliidm
approved these changes
Dec 14, 2023
Contributor
|
@elastic/security-detection-rule-management @elastic/security-threat-hunting-investigations @elastic/security-threat-hunting-explore @elastic/kibana-visualizations @elastic/kibana-data-discovery @elastic/response-ops @elastic/fleet @elastic/kibana-design - last ping for reviews. We'll be asking KibanaOps to admin merge on Monday. |
banderror
approved these changes
Dec 15, 2023
Contributor
banderror
left a comment
banderror
left a comment
There was a problem hiding this comment.
Changes for the Rule Management page (x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_table_filters/rule_search_field.tsx) LGTM -- tested this locally.
As long as CI is happy with the rest of the changes in tests, I'm happy too 👍
Contributor
|
/ci |
Contributor
|
Wow I see some bundle sizes decrease 👏 |
stratoula
approved these changes
Dec 18, 2023
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Visualizations team changes LGTM
angorayc
approved these changes
Dec 18, 2023
stephmilovic
approved these changes
Dec 18, 2023
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
LGTM for explore team. thanks!
Contributor
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @tkajtoch |
Contributor
|
We just spoke to @jbudz and @kevinlog and received acknowledgement / approval that the failing Cypress Defend tests are not related to the EUI upgrade (thank you so much for merging in main to check however Stratoula/Steph, y'all are awesome)! As this PR has been open for a while now, and we've alerted multiple teams at various times, we'll be moving forward with asking for an admin merge on this PR shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v90.0.0⏩v91.0.0-backport.0The changes in EUI that required a large swathe of these updates are:
<div>wrapper on its anchors, which affected many snapshots and a few CSS overrides, which should have been updated<button>elements instead of<input type="radio">elements for single selection, which affected both snapshots and E2E testsEnterkeypress when parsing dates (affected E2E tests)singleSelection={{ plainText: 'true' }}, no longer renders a pill (i.e. text). This combobox type now behaves more like anEuiFieldText, where the selection is rendered via inputvalueinstead. This affected a high amount of E2E tests (both FTR and Cypress), both in terms of updating assertions and changing selections, but should not significantly affect user experience - see [EuiComboBox] RefactorsingleSelection.asPlainTextto make greater use of the underlyinginputelement eui#7332 for more.v91.0.0-backport.0This is a backport release only intended for use by Kibana.
esqlVis,pipeBreaks, andpipeNoBreaksicon glyphs.EuiSelectablenow allows configurable text truncation vialistProps.truncationProps(#7388)EuiTextTruncatenow supports a newcalculationDelayMsprop for working around font loading or layout shifting scenarios (#7388)Bug fixes
EuiSelectables with customtruncationProps, where scrollbar widths were not being accounted for (#7392)91.0.0EuiPopovers in dark mode to increase visibility & contrast against other page/panel backgrounds (#7310)EuiDataGridto prevent unneeded re-renders (#7324)roleprop toEuiAccordion(#7326)roleprop toEuiGlobalToastList(#7328)EuiSuperDatePickernow allows users to paste ISO 8601, RFC 2822, and Unix timestamps in theAbsolutetab input, in addition to timestamps in thedateFormatprop (#7331)EuiComboBoxes now behave more like a normal text field/input. Backspacing will no longer delete the entire value, and selected values can now be double clicked and copied. (#7332)EuiDataGrid's display settings popover now allows users to clear the "Lines per row" input before typing in a new number (#7338)EuiSuperDatePicker's Absolute tab for users manually typing in timestamps (#7341)EuiI18ns with multipletokensto accept dynamicvalues(#7341)Bug fixes
EuiComboBox'sonSearchChangecallback to pass the correcthasMatchingOptionsvalue (#7334)EuiSelectableTemplateSitewidebug where thepopoverButtonbehavior would break if passed a non-DOM React wrapper (#7339)Deprecations
EuiPopover: deprecatedanchorClassName. UseclassNameinstead (#7311)EuiPopover: deprecatedbuttonRef. UsepopoverRefinstead (#7311)EuiPopover: removed extra.euiPopover__anchordiv wrapper. Target.euiPopoverinstead if necessary (#7311)EuiButtonGroup'snameprop. This can safely be removed. (#7325)Breaking changes
euiPaletteComplimentary- useeuiPaletteComplementaryInstead (#7333)Accessibility
type="single"EuiButtonGroups to render standard buttons instead of radio buttons under the hood, per recent a11y recommendations (#7325)EuiAccordionnow defaults to a less screenreader-noisygrouprole instead ofregion. If your accordion contains significant enough content to be a document landmark role, you may re-configure it back toregion. (#7326)EuiDataGridcolumns via toolbar (#7327)EuiGlobalToastListnow defaults to alogrole. If your toasts will always require immediate user action, consider (with caution) using thealertrole instead. (#7328)CSS-in-JS conversions
$euiFontFamilyand$euiCodeFontFamilyto match Emotion fonts (#7332)