Adding Usage Telemetry for Detection Rules & Security Lists Tasks#170056
Merged
Adding Usage Telemetry for Detection Rules & Security Lists Tasks#170056
Conversation
KeerthyND
added
Feature:Telemetry
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
pjhampton
reviewed
Nov 2, 2023
Contributor
pjhampton
left a comment
pjhampton
left a comment
There was a problem hiding this comment.
Cool! I think you are nearly there
x-pack/plugins/security_solution/server/lib/telemetry/tasks/detection_rule.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/telemetry/tasks/detection_rule.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/telemetry/receiver.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/telemetry/receiver.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/telemetry/sender.ts
Outdated
Show resolved
Hide resolved
pjhampton
approved these changes
Nov 14, 2023
szaffarano
approved these changes
Nov 27, 2023
| LIST_TRUSTED_APPLICATION | ||
| ); | ||
| count += trustedAppsJson.length; | ||
| tlog(logger, `Trusted Apps: ${trustedAppsJson}`); |
Contributor
There was a problem hiding this comment.
I think it's better not to log the whole JSON but just the relevant info, eg num or records, WDYT?
Contributor
There was a problem hiding this comment.
Agree with this given the recent incident. I pushed something into b93311b
💚 Build Succeeded
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @KeerthyND |
donaherc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding Usage Telemetry for Detection Rules & Secuirty Lists Tasks
Checklist
Delete any items that are not applicable to this PR.