Merged
Conversation
timroes
added
the
bug
stacey-gammon
approved these changes
Mar 7, 2018
stacey-gammon
left a comment
stacey-gammon
left a comment
There was a problem hiding this comment.
LGTM pending passing ci. Just pointing out that it looks like you switched from 1.0.0 in the old PR to 2.1.1 but as long as it all still works on 2.1.1, and you are aware, lgtm!
Contributor
💚 Build Succeeded |
|
Since I believe this is breaking the build on master... I'm going to go ahead and merge into master now that the PR is passing. |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Mar 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a missing dependency in
yarn.lock, that was introduced due to an old PR (#12753) by me, that has been created before the switch to yarn.