[Defend Workflows] Enable FTRs for serverless using tags#169946
Merged
gergoabraham merged 23 commits intoelastic:mainfrom Nov 1, 2023
Merged
[Defend Workflows] Enable FTRs for serverless using tags#169946gergoabraham merged 23 commits intoelastic:mainfrom
gergoabraham merged 23 commits intoelastic:mainfrom
Conversation
gergoabraham
added
release_note:skip
gergoabraham
force-pushed
the
serverless-tags-for-security-solution-ftrs
branch
from
c8a5b8f to
6a2fd4c
Compare
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
jbudz
reviewed
Oct 30, 2023
x-pack/test/security_solution_endpoint/apps/endpoint/responder.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
jbudz
approved these changes
Oct 31, 2023
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
LGTM. I added appex-qa as an optional reviewer for the discussion on #169946 (comment).
I know we're running tests with a filter on the skip mki tag, but I believe it's only for certain suites. Want to make @elastic/appex-qa aware of the skipInServerless tag too.
joeypoon
approved these changes
Nov 1, 2023
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
) ## Summary This PR enables **most of** our FTR tests in `x-pack/test/security_solution_endpoint/` to run against both ESS and Serverless, using the following tags: - `@ess` - `@serverless` - `@brokenInServerless` - `@skipInServerless` - `@skipInEss` The ones that are not enabled are the ones that use different users/roles. ### Usage ```ts describe('This is the suite.', function() { // a custom function wraps the `this.tags()` function to provide type safety targetTags(this, ['@ess', '@serverless', '@skipInServerless']); }) ``` > **Note** > Only `describe()` blocks can be tagged. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gergoabraham
added a commit
that referenced
this pull request
Nov 9, 2023
…70418) ## Summary With a similar solution as #169946, almost all of our FTR API tests (`x-pack/test/security_solution_endpoint_api_int/`) can now run against serverless, using `suiteTags` under the hood. ## Usage ```ts describe('This is the suite.', function() { // a custom function wraps the `this.tags()` function to provide type safety targetTags(this, ['@ess', '@serverless', '@skipInServerless']); }) ``` > **Note** > Only `describe()` blocks can be tagged. ## Changes: - serverless config is added for endpoint FTR API tests: `x-pack/test/security_solution_endpoint_api_int/serverless.config.ts` - roles are created only when running against ESS. when running against serverless, a subset of users/roles already exist (see [this list](https://github.com/elastic/kibana/pull/170418/files#diff-5aaeaeaedad4321151d5388437084b27f271a6254e95f0352c9a10c3126eddc8R54)) - tests that use roles that doesn't exist on serverless (`artifact_read_privileges`, `hunter`) are therefore skipped against serverless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables most of our FTR tests in
x-pack/test/security_solution_endpoint/to run against both ESS and Serverless, using the following tags:@ess@serverless@brokenInServerless@skipInServerless@skipInEssThe ones that are not enabled are the ones that use different users/roles.
Usage