Skip to content

[EDR Workflows] Policy Settings - view mode #169920

Merged
szwarckonrad merged 3 commits intoelastic:mainfrom
szwarckonrad:fix-view-mode-card
Oct 26, 2023
Merged

[EDR Workflows] Policy Settings - view mode #169920
szwarckonrad merged 3 commits intoelastic:mainfrom
szwarckonrad:fix-view-mode-card

Conversation

@szwarckonrad
Copy link
Copy Markdown
Contributor

@szwarckonrad szwarckonrad commented Oct 26, 2023 •
edited
Loading

#168428

This pull request modifies the way a user views policy details settings when they lack write permissions.
We want to hide card's content if protection is disabled.

Screen.Recording.2023-10-26.at.12.27.17.mov

@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0 labels Oct 26, 2023
@szwarckonrad szwarckonrad self-assigned this Oct 26, 2023
@szwarckonrad szwarckonrad requested a review from a team as a code owner October 26, 2023 10:36
@szwarckonrad szwarckonrad requested a review from joeypoon October 26, 2023 10:36
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 26, 2023

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@szwarckonrad szwarckonrad mentioned this pull request Oct 26, 2023
Closed
tomsonpl
tomsonpl approved these changes Oct 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 26, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / serverless observability UI Rules list should disable single rule

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +746.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit 9b0e24f into elastic:main Oct 26, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon was automatically assigned from elastic/security-defend-workflows

Assignees

@szwarckonrad szwarckonrad

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@szwarckonrad @elasticmachine @kibana-ci @tomsonpl @paul-tavares @kibanamachine