[Security Solution] Unskip and enable for Serverless shared_exception_lists_management Cypress tests#169182
Merged
jpdjere merged 10 commits intoelastic:mainfrom Nov 3, 2023
Conversation
jpdjere
changed the title
shared_exception_lists_management Cypress tests
This was referenced Oct 19, 2023
TokenPayId
approved these changes
Oct 23, 2023
TokenPayId
left a comment
TokenPayId
left a comment
There was a problem hiding this comment.
jpdjere:flaky-run-shared_exception_lists_management
jpdjere
added
release_note:fix
Team:Detections and Resp
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
jpdjere
changed the title
shared_exception_lists_management Cypress testsshared_exception_lists_management Cypress tests
yctercero
approved these changes
Oct 30, 2023
Contributor
yctercero
left a comment
yctercero
left a comment
There was a problem hiding this comment.
LGTM, but running flakey test runner one more time as that last link in the description showed failures so just want to be sure - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3828
jpdjere
force-pushed
the
flaky-run-shared_exception_lists_management
branch
from
cbb51c7 to
48b82a6
Compare
Contributor
Author
- |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jpdjere |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
@jpdjere The backport has failed, would you mind backporting manually? Please make sure to not backport the erroneously merged changes to the |
jpdjere
added a commit
to jpdjere/kibana
that referenced
this pull request
Nov 6, 2023
…n_lists_management` Cypress tests (elastic#169182) ## Summary Running flaky test runner for: - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management` ## Changes - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/list_detail_page/list_details.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/filter_table.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/import_lists.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/manage_lists.cy.ts` **unskipped and enabled in Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/read_only.cy.ts` **removed from Serverless testing** ## Related failing-test issues 1. elastic#165874 2. elastic#165838 3. elastic#165795 4. elastic#165743 - **Closed as duplicate of _#165640** 5. elastic#165690 6. elastic#165640 ### Flaky test runner link - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3557#_ (Only ESS) 🟢 - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3564#_ (ESS and Serverless) - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3613 (Serverless evaluated and corrected) - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3878 [V3] - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3891 [V4] (cherry picked from commit c0c7d13) # Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/list_detail_page/list_details.cy.ts # x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts # x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/manage_lists.cy.ts # x-pack/test/security_solution_cypress/package.json
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
9 tasks
banderror
added a commit
that referenced
this pull request
Nov 6, 2023
…oductivity team (#170662) ## Summary This PR makes the @elastic/security-engineering-productivity team the owner of the `x-pack/test/security_solution_cypress/package.json` file to prevent accidentally merging temporary changes to this file like in #169182. Also, it simplifies the ownership rules a bit. The following lines assign the team to all files under the two specified folders, but not files inside their subfolders, so you don't have to specify individual files: ``` /x-pack/test/security_solution_cypress/* @elastic/security-engineering-productivity /x-pack/test/security_solution_cypress/cypress/* @elastic/security-engineering-productivity ```
jpdjere
added a commit
that referenced
this pull request
Nov 6, 2023
…xception_lists_management` Cypress tests (#169182) (#170669) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Unskip and enable for Serverless `shared_exception_lists_management` Cypress tests (#169182)](#169182) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2023-11-03T22:35:09Z","message":"[Security Solution] Unskip and enable for Serverless `shared_exception_lists_management` Cypress tests (#169182)\n\n## Summary\r\n\r\nRunning flaky test runner for:\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/list_detail_page/list_details.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/filter_table.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/import_lists.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/manage_lists.cy.ts`\r\n**unskipped and enabled in Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/read_only.cy.ts`\r\n**removed from Serverless testing**\r\n\r\n\r\n## Related failing-test issues\r\n1. https://github.com/elastic/kibana/issues/165874\r\n2. https://github.com/elastic/kibana/issues/165838\r\n3. https://github.com/elastic/kibana/issues/165795\r\n4. #165743 - **Closed as\r\nduplicate of _#165640**\r\n5. https://github.com/elastic/kibana/issues/165690\r\n6. https://github.com/elastic/kibana/issues/165640\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3557#_\r\n(Only ESS) 🟢\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3564#_\r\n(ESS and Serverless)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3613\r\n(Serverless evaluated and corrected)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3878\r\n[V3]\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3891\r\n[V4]","sha":"c0c7d1365f9e034128de8cbb03ac5733aefcd22f","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Team:Detection Engine","v8.11.0","v8.12.0"],"number":169182,"url":"https://github.com/elastic/kibana/pull/169182","mergeCommit":{"message":"[Security Solution] Unskip and enable for Serverless `shared_exception_lists_management` Cypress tests (#169182)\n\n## Summary\r\n\r\nRunning flaky test runner for:\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/list_detail_page/list_details.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/filter_table.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/import_lists.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/manage_lists.cy.ts`\r\n**unskipped and enabled in Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/read_only.cy.ts`\r\n**removed from Serverless testing**\r\n\r\n\r\n## Related failing-test issues\r\n1. https://github.com/elastic/kibana/issues/165874\r\n2. https://github.com/elastic/kibana/issues/165838\r\n3. https://github.com/elastic/kibana/issues/165795\r\n4. #165743 - **Closed as\r\nduplicate of _#165640**\r\n5. https://github.com/elastic/kibana/issues/165690\r\n6. https://github.com/elastic/kibana/issues/165640\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3557#_\r\n(Only ESS) 🟢\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3564#_\r\n(ESS and Serverless)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3613\r\n(Serverless evaluated and corrected)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3878\r\n[V3]\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3891\r\n[V4]","sha":"c0c7d1365f9e034128de8cbb03ac5733aefcd22f"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169182","number":169182,"mergeCommit":{"message":"[Security Solution] Unskip and enable for Serverless `shared_exception_lists_management` Cypress tests (#169182)\n\n## Summary\r\n\r\nRunning flaky test runner for:\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/list_detail_page/list_details.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/filter_table.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/import_lists.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/manage_lists.cy.ts`\r\n**unskipped and enabled in Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/read_only.cy.ts`\r\n**removed from Serverless testing**\r\n\r\n\r\n## Related failing-test issues\r\n1. https://github.com/elastic/kibana/issues/165874\r\n2. https://github.com/elastic/kibana/issues/165838\r\n3. https://github.com/elastic/kibana/issues/165795\r\n4. #165743 - **Closed as\r\nduplicate of _#165640**\r\n5. https://github.com/elastic/kibana/issues/165690\r\n6. https://github.com/elastic/kibana/issues/165640\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3557#_\r\n(Only ESS) 🟢\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3564#_\r\n(ESS and Serverless)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3613\r\n(Serverless evaluated and corrected)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3878\r\n[V3]\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3891\r\n[V4]","sha":"c0c7d1365f9e034128de8cbb03ac5733aefcd22f"}}]}] BACKPORT-->
banderror
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
banderror
added
test
release_note:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running flaky test runner for:
x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_managementChanges
x-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/list_detail_page/list_details.cy.tsenabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.tsenabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/manage_exceptions.cy.tsenabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/filter_table.cy.tsenabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/import_lists.cy.tsenabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/manage_lists.cy.tsunskipped and enabled in Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/shared_exception_lists_management/shared_exception_list_page/read_only.cy.tsremoved from Serverless testingRelated failing-test issues
Flaky test runner link