Skip to content

Upgrade EUI to v89.1.0 #169135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cee-chen merged 6 commits into from
Oct 19, 2023
Merged

Upgrade EUI to v89.1.0 #169135

cee-chen merged 6 commits into from
Oct 19, 2023

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Oct 17, 2023 •
edited
Loading

v89.0.0⏩v89.1.0

This upgrade also contains an EuiDataGrid refactor (elastic/eui#7255) not listed in the changelog (as no end-user functionality or props changed as a result of the refactor). The unlisted changes should only affect DOM and className usages in Kibana (primarily CSS overrides and test selectors).

89.1.0

  • Added tokenVectorSparse token and updated tokenDenseVector token (now named tokenVectorDense). (#7282)

CSS-in-JS conversions

  • Reduced default CSS prefixes generated by Emotion to only browsers supported by EUI (latest evergreen browsers). This can be customized by passing your own Emotion cache to EuiProvider. (#7272)

@cee-chen
Upgrade EUI to v89.1.0
c2551e8
@cee-chen
Update all EuiProvider Emotion caches to use new EUI prefixer plugin
d9ad7f0 
- which reduces the amount of default prefixes Emotion outputs
@cee-chen
[EuiDataGrid] Update various CSS classes/styles
531146f 
- to account for cell DOM refactored in elastic/eui#7255
@cee-chen
[EuiDataGrid] Update test selectors
95f46c1 
- to account for updated DOM
cee-chen and others added 2 commits October 17, 2023 13:49
@cee-chen
Merge branch 'main' into eui-89.1.x
605c0da
@cee-chen
[osquery] Fix broken Cypress selector
e5d754e 
`.getBySel` already appears to include `[data-test-subj=]` in it, so the query is broken
@kibana-ci
Copy link

kibana-ci commented Oct 17, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1414 1418 +4
visTypeVega 308 310 +2
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 53.1KB 53.2KB +76.0B
aiops 587.3KB 587.3KB +72.0B
apm 3.7MB 3.7MB +1.0B
canvas 1012.0KB 1012.1KB +72.0B
cloudSecurityPosture 399.5KB 399.3KB -183.0B
dashboard 375.4KB 375.5KB +77.0B
data 48.3KB 48.4KB +76.0B
dataViewManagement 117.5KB 117.5KB +70.0B
dataVisualizer 614.5KB 614.6KB +72.0B
discover 575.9KB 575.8KB -88.0B
exploratoryView 201.0KB 201.0KB +1.0B
fileUpload 957.5KB 957.5KB +1.0B
graph 388.0KB 388.1KB +76.0B
infra 1.9MB 1.9MB +10.7KB
links 25.3KB 25.3KB +72.0B
ml 3.5MB 3.5MB +72.0B
monitoring 462.4KB 462.4KB +1.0B
observability 1.0MB 1.0MB +144.0B
observabilityAIAssistant 201.2KB 201.3KB +72.0B
reporting 61.8KB 61.8KB +74.0B
securitySolution 13.0MB 13.0MB +45.0B
serverlessSearch 126.1KB 126.3KB +144.0B
share 5.5KB 5.6KB +72.0B
synthetics 865.5KB 865.5KB +1.0B
transform 402.5KB 402.5KB +72.0B
uptime 478.3KB 478.3KB +1.0B
visTypeVega 1.8MB 1.8MB +10.3KB
total +22.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudChat 13.0KB 13.1KB +72.0B
cloudLinks 15.7KB 15.8KB +72.0B
core 367.5KB 367.6KB +76.0B
dataViewEditor 12.7KB 12.8KB +72.0B
dataViewFieldEditor 25.2KB 25.3KB +72.0B
embeddable 78.1KB 78.2KB +75.0B
interactiveSetup 61.2KB 61.3KB +76.0B
kbnUiSharedDeps-css 265.1KB 263.8KB -1.3KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +1.9KB
kibanaReact 47.2KB 47.3KB +74.0B
kibanaUtils 73.6KB 73.7KB +77.0B
logsShared 219.1KB 219.1KB +1.0B
management 13.6KB 13.6KB +72.0B
navigation 11.6KB 11.7KB +72.0B
observability 101.3KB 101.3KB +1.0B
observabilityLogExplorer 18.4KB 18.5KB +74.0B
visTypeVega 33.8KB 33.8KB -54.0B
total +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review October 17, 2023 23:57
@cee-chen cee-chen requested review from a team as code owners October 17, 2023 23:57
tomsonpl
tomsonpl approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defend Workflows changes LGTM 👍

sebelga
sebelga approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomheymann
thomheymann approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM

ymao1
ymao1 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Ops changes LGTM

maxcold
maxcold approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud_securty_posture changes LGTM

MichaelMarcialis
MichaelMarcialis approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only. LGTM.

@cee-chen
Copy link
Contributor Author

cee-chen commented Oct 19, 2023

Thanks all! As always, feel free to ping us anytime if you find any regressions or issues that you think was caused by this PR!

@cee-chen cee-chen merged commit feab0c6 into elastic:main Oct 19, 2023
@cee-chen cee-chen deleted the eui-89.1.x branch October 19, 2023 18:41
@kibanamachine kibanamachine added v8.12.0 backport:skip This PR does not require backporting labels Oct 19, 2023
@maryam-saeidi maryam-saeidi mentioned this pull request Oct 26, 2023
Closed
@kertal kertal mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janmonschke janmonschke janmonschke approved these changes

@thomheymann thomheymann thomheymann approved these changes

@maxcold maxcold maxcold approved these changes

@jbudz jbudz jbudz approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@ymao1 ymao1 ymao1 approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya is a code owner automatically assigned from elastic/security-defend-workflows

@parkiino parkiino Awaiting requested review from parkiino parkiino is a code owner automatically assigned from elastic/security-defend-workflows

+1 more reviewer

@sebelga sebelga sebelga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.