[Security Solutions] Fix entity analytics dashboard error that appear during cypress tests#168709
Merged
machadoum merged 7 commits intoelastic:mainfrom Oct 17, 2023
Merged
Conversation
machadoum
added
Team:Threat Hunting
machadoum
force-pushed
the
siem-ea-fix-cypress-test
branch
from
e9affe5 to
f890332
Compare
machadoum
force-pushed
the
siem-ea-fix-cypress-test
branch
from
f890332 to
f9f7773
Compare
machadoum
commented
Oct 13, 2023
Comment on lines
+84
to
+89
| !skip && | ||
| defaultIndex && | ||
| !isDeprecatedLoading && | ||
| isAuthorized && | ||
| isEnabled && | ||
| !isDeprecated |
Member
Author
There was a problem hiding this comment.
Apply the same check we do when fetching risk scores:
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
machadoum
added
technical debt
…-ref HEAD~1..HEAD --fix'
kdelemme
approved these changes
Oct 17, 2023
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
AO code change looks good to me
💔 Build FailedFailed CI Steps
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 18, 2023
… during cypress tests (elastic#168709) ## Summary Fix Entity analytics dashboard error that popped up during Cypress tests. Solutions: I added the same check we have for the risk score fetch to the risk score KPI fetch. It prevents the UI from fetching the KPI when the index doesn't exist. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Entity analytics dashboard error that popped up during Cypress tests.
Solutions:
I added the same check we have for the risk score fetch to the risk score KPI fetch.
It prevents the UI from fetching the KPI when the index doesn't exist.
Checklist