Merged
Conversation
- mostly removing strings from deprecated components
cee-chen
added
release_note:skip
- tests fail otherwise, as the popover has `pointer-events: none` while transitioning in
- Diff is likely due to fixed `EuiFlexGroup` gap sizing - will leave it to the team to update the screenshots
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/eui-team (EUI) |
PhilippeOberti
approved these changes
Oct 9, 2023
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
LGTM for the Threat Hunting Investigations team!
jcger
approved these changes
Oct 10, 2023
janmonschke
approved these changes
Oct 10, 2023
Contributor
janmonschke
left a comment
janmonschke
left a comment
There was a problem hiding this comment.
Security changes LGTM 👍
Ikuni17
approved these changes
Oct 10, 2023
MichaelMarcialis
approved these changes
Oct 10, 2023
maxcold
approved these changes
Oct 11, 2023
Contributor
maxcold
left a comment
maxcold
left a comment
There was a problem hiding this comment.
cloud_defend changes LGTM
Contributor
|
Merging on behalf of Cee for the EUI team. |
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
`v88.5.4`⏩`v89.0.0` --- ## [`89.0.0`](https://github.com/elastic/eui/tree/v89.0.0) - Added new `pushAnimation` prop to push `EuiFlyout`s, which enables a slide in animation ([elastic#7239](elastic/eui#7239)) - Updated `EuiComboBox` to use `EuiInputPopover` under the hood ([elastic#7246](elastic/eui#7246)) - Added `inputPopoverProps` to `EuiComboBox`, which allows customizing the underlying popover ([elastic#7246](elastic/eui#7246)) - Added a new beta `EuiTextBlockTruncate` component for multi-line truncation ([elastic#7250](elastic/eui#7250)) - Updated `EuiBasicTable` and `EuiInMemoryTable` to support multi-line truncation. This can be set via `truncateText.lines` in the `columns` prop. ([elastic#7254](elastic/eui#7254)) **Bug fixes** - Fixed `EuiFlexGroup` and `EuiFlexGrid`'s `m` gutter size ([elastic#7251](elastic/eui#7251)) - Fixed focus trap rerender issues in `EuiFlyout` with memoization ([elastic#7259](elastic/eui#7259)) - Fixed a visual bug with `EuiContextMenu`'s animation between panels ([elastic#7268](elastic/eui#7268)) **Breaking changes** - EUI's global body font-size now respects the `font.defaultUnits` token. This means that the global font size will use the `rem` unit by default, instead of `px`. ([elastic#7182](elastic/eui#7182)) - Removed exported `accessibleClickKeys`, `comboBoxKeys`, and `cascadingMenuKeys` services. Use the generic `keys` service instead ([elastic#7256](elastic/eui#7256)) - Removed `EuiColorStops` due to low usage ([elastic#7262](elastic/eui#7262)) - Removed `EuiSuggest`. We recommend using `EuiSelectable` or `EuiComboBox` instead ([elastic#7263](elastic/eui#7263)) - Removed `euiHeaderAffordForFixed` Sass mixin, and `$euiHeaderHeight` and `$euiHeaderHeightCompensation` Sass variables. Use the CSS variable `--var(euiFixedHeadersOffset, 0)` instead. ([elastic#7264](elastic/eui#7264)) **Accessibility** - When using `rem` or `em` font units, EUI now respects, instead of ignoring, browser default font sizes set by end users. ([elastic#7182](elastic/eui#7182))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v88.5.4⏩v89.0.089.0.0pushAnimationprop to pushEuiFlyouts, which enables a slide in animation (#7239)EuiComboBoxto useEuiInputPopoverunder the hood (#7246)inputPopoverPropstoEuiComboBox, which allows customizing the underlying popover (#7246)EuiTextBlockTruncatecomponent for multi-line truncation (#7250)EuiBasicTableandEuiInMemoryTableto support multi-line truncation. This can be set viatruncateText.linesin thecolumnsprop. (#7254)Bug fixes
EuiFlexGroupandEuiFlexGrid'smgutter size (#7251)EuiFlyoutwith memoization (#7259)EuiContextMenu's animation between panels (#7268)Breaking changes
font.defaultUnitstoken. This means that the global font size will use theremunit by default, instead ofpx. (#7182)accessibleClickKeys,comboBoxKeys, andcascadingMenuKeysservices. Use the generickeysservice instead (#7256)EuiColorStopsdue to low usage (#7262)EuiSuggest. We recommend usingEuiSelectableorEuiComboBoxinstead (#7263)euiHeaderAffordForFixedSass mixin, and$euiHeaderHeightand$euiHeaderHeightCompensationSass variables. Use the CSS variable--var(euiFixedHeadersOffset, 0)instead. (#7264)Accessibility
remoremfont units, EUI now respects, instead of ignoring, browser default font sizes set by end users. (#7182)