Fix KibanaPageTemplate.BottomBar in serverless#168235
Merged
semd merged 1 commit intoelastic:mainfrom Oct 6, 2023
Merged
Conversation
semd
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: cc @semd |
MichaelMarcialis
approved these changes
Oct 6, 2023
Contributor
MichaelMarcialis
left a comment
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Code review only. LGTM.
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
## Summary The latest changes applied [here ](elastic#166840) caused the `KibanaPageTemplate.BottomBar` to not work properly:  The `margin-left` should be applied only to `.euiBottomBar--fixed` instead of all `.euiBottomBar`, `--sticky` and `--static` are already positioned correctly to the relative parent, so no margin needs to be applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The latest changes applied here caused the
KibanaPageTemplate.BottomBarto not work properly:The
margin-leftshould be applied only to.euiBottomBar--fixedinstead of all.euiBottomBar,--stickyand--staticare already positioned correctly to the relative parent, so no margin needs to be applied.