sparse_vector field support#168186
Conversation
| <EuiToken | ||
| aria-label="sparse_vector" | ||
| className="kbnFieldIcon" | ||
| iconType="tokenDenseVector" |
There was a problem hiding this comment.
Do we want to use tokenDenseVector or should we create a new token for sparse vector?
There was a problem hiding this comment.
I have already asked for a specific field icon in elastic/eui#7257. I think we can update that when / if ready.
| _source: { iconType: 'editorCodeBlock', color: 'gray' }, | ||
| point: { iconType: 'tokenShape' }, // there is no separate icon for `point` yet | ||
| shape: { iconType: 'tokenShape' }, | ||
| sparse_vector: { iconType: 'tokenDenseVector' }, |
There was a problem hiding this comment.
Same question here, do we want to use tokenDenseVector or should we create a new token for sparse vector?
There was a problem hiding this comment.
@andreadelrio do we have an icon we can use or add to eui?
There was a problem hiding this comment.
Andrea is already pinged in elastic/eui#7257 (comment). 😉 My plan is to open a separate PR when that's ready.
jughosta
left a comment
jughosta
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
| </p> | ||
| ), | ||
| }, | ||
| sparse_vector: { |
There was a problem hiding this comment.
Hi @carlosdelest, just a question: why are we adding these changes to the Index management plugin?
Did you mean to add support for the sparse_vector field type in the Mappings editor?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for clarifying! Tested locally and LGTM.
…_field_support' into carlosdelest/sparse_vector_field_support
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Index management changes LGTM
| </p> | ||
| ), | ||
| }, | ||
| sparse_vector: { |
There was a problem hiding this comment.
Thanks for clarifying! Tested locally and LGTM.
7 participants
Summary
Add
sparse_vectorfield support (added to Elasticsearch here) for Discovery. Specific field icon is pending this EUI issue:Field type:
Field filter:
Field in doc table:
It also uses
sparse_vectoras the field mapping for ELSER based ML pipelines created using Kibana:Checklist
Delete any items that are not applicable to this PR.