Closed
Conversation
Ikuni17
added
release_note:skip
💔 Build FailedFailed CI Steps
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: cc @Ikuni17 |
Contributor
Author
|
Closing in favor of #167428 |
delanni
added a commit
that referenced
this pull request
Oct 2, 2023
… to cypress (#167428) (#167614) Backport of #167428 Replaces: #167581 Part of: #167373 --- The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the `tsconfig.json`s, leading to hard-to-resolve typescript issues. This PR moves the configs in, and cleans up redundancies and type errors. chore(osquery): move osquery/cypress configs to cypress folder, fix type errors --------- Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> Co-authored-by: Brad White <brad.white@elastic.co> (cherry picked from commit e84742d) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially fixes #167373 for:
./x-pack/plugins/osquery/cypress/tsconfig.json