Skip to content

Revert "[inspector] show request method, path, and querystring"#167485

Merged
delanni merged 2 commits intoelastic:mainfrom
rudolf:revert-pr-166565
Sep 28, 2023
Merged

Revert "[inspector] show request method, path, and querystring"#167485
delanni merged 2 commits intoelastic:mainfrom
rudolf:revert-pr-166565

Conversation

@rudolf
Copy link
Contributor

@rudolf rudolf commented Sep 28, 2023

This reverts commit d61a5a0 from #166565

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf requested review from a team as code owners September 28, 2023 09:56
@rudolf rudolf added release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// labels Sep 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / serverless common UI Index Management Create enrich policy can create an enrich policy
  • [job] [logs] FTR Configs #51 / serverless observability UI landing page has quickstart badge

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inspector 57 56 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaUtils 419 417 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inspector 26.4KB 26.2KB -203.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 407.9KB 407.7KB -205.0B
inspector 22.2KB 21.8KB -414.0B
total -619.0B
Unknown metric groups

API count

id before after diff
data 3310 3308 -2
kibanaUtils 612 610 -2
total -4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit 239e503 into elastic:main Sep 28, 2023
@delanni
Copy link
Contributor

delanni commented Sep 28, 2023

Admin merging, considering this is a revert, and time sensitive.

@kibanamachine kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Sep 28, 2023
@rudolf rudolf deleted the revert-pr-166565 branch September 28, 2023 13:25
nreese added a commit to nreese/kibana that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants