Skip to content

[Lens] Mute visualization modifier badge if layer has only manual annotations#167483

Merged
dej611 merged 4 commits intoelastic:mainfrom
dej611:fix/167408
Sep 28, 2023
Merged

[Lens] Mute visualization modifier badge if layer has only manual annotations#167483
dej611 merged 4 commits intoelastic:mainfrom
dej611:fix/167408

Conversation

@dej611
Copy link
Contributor

@dej611 dej611 commented Sep 28, 2023

Summary

Fixes #167408

This PR reduces the amount of "visualization modifiers" in the specific case where ALL annotations in a layer are manual.
The Ignore global filters will still be shown if at least one query-based annotation is defined in the layer.

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.11.0 labels Sep 28, 2023
@dej611 dej611 requested a review from a team as a code owner September 28, 2023 09:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! Thanx for the tests, tested it locally in Chrome and works as expected

@drewdaemon
Copy link
Contributor

You beat me! Thanks @dej611 ! :)

@dej611 dej611 enabled auto-merge (squash) September 28, 2023 13:09
@dej611 dej611 merged commit 911ed80 into elastic:main Sep 28, 2023
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +44.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't show warning for static Annotations

6 participants