[Lens] Mute visualization modifier badge if layer has only manual annotations#167483
Merged
dej611 merged 4 commits intoelastic:mainfrom Sep 28, 2023
Merged
[Lens] Mute visualization modifier badge if layer has only manual annotations#167483dej611 merged 4 commits intoelastic:mainfrom
dej611 merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
approved these changes
Sep 28, 2023
Contributor
stratoula
left a comment
There was a problem hiding this comment.
This works great! Thanx for the tests, tested it locally in Chrome and works as expected
Contributor
|
You beat me! Thanks @dej611 ! :) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167408
This PR reduces the amount of "visualization modifiers" in the specific case where ALL annotations in a layer are manual.
The
Ignore global filterswill still be shown if at least one query-based annotation is defined in the layer.Checklist
Delete any items that are not applicable to this PR.