Skip to content

[Type Check] Add newly included AlertStatus item to the infra tests#167470

Merged
crespocarlos merged 1 commit intoelastic:mainfrom
crespocarlos:infra-ui-fix-typing
Sep 28, 2023
Merged

[Type Check] Add newly included AlertStatus item to the infra tests#167470
crespocarlos merged 1 commit intoelastic:mainfrom
crespocarlos:infra-ui-fix-typing

Conversation

@crespocarlos
Copy link
Contributor

Summary

This PR fix type check problems caused by the inclusion of a new item in the AlertStatus union type

@ghost
Copy link

ghost commented Sep 28, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.11.0 labels Sep 28, 2023
@crespocarlos crespocarlos marked this pull request as ready for review September 28, 2023 09:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit 8a2701c into elastic:main Sep 28, 2023
@crespocarlos crespocarlos deleted the infra-ui-fix-typing branch September 28, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants