[Cloud Security] Azure support for dashboard and flyout and PLG for dashboard#167422
[Cloud Security] Azure support for dashboard and flyout and PLG for dashboard#167422JordanSh merged 3 commits intoelastic:mainfrom
Conversation
JordanSh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @JordanSh |
opauloh
left a comment
opauloh
left a comment
There was a problem hiding this comment.
LGTM, only a few optional suggestions that can be addressed later
| <EuiButtonEmpty | ||
| iconType="listAdd" | ||
| target="_blank" | ||
| href={ | ||
| dashboardType === KSPM_POLICY_TEMPLATE ? kspmIntegrationLink : cspmIntegrationLink | ||
| } | ||
| > | ||
| {dashboardType === KSPM_POLICY_TEMPLATE | ||
| ? i18n.translate( | ||
| 'xpack.csp.dashboard.summarySection.counterCard.clustersEvaluatedButtonTitle', | ||
| { defaultMessage: 'Enroll more clusters' } | ||
| ) | ||
| : i18n.translate( | ||
| 'xpack.csp.dashboard.summarySection.counterCard.accountsEvaluatedButtonTitle', | ||
| { defaultMessage: 'Enroll more accounts' } | ||
| )} | ||
| </EuiButtonEmpty> |
There was a problem hiding this comment.
It feels this could be better if splitting into two buttons
There was a problem hiding this comment.
yeah i agree but its pretty small so i prefer to just merge for now
| navToFindings({ 'rule.benchmark.id': cisBenchmark }); | ||
| }; | ||
|
|
||
| const benchmarkElements = benchmarks.map((benchmark) => { |
There was a problem hiding this comment.
think it's a good candidate to wrap with useMemo()
There was a problem hiding this comment.
while possible, it also means wrapping all the hooks in usecallbacks and for such small component all those memos are not worth it in my opinion
| :hover { | ||
| cursor: pointer; | ||
| border-color: ${euiTheme.colors.darkestShade}; |
5 participants
Summary
Resolves #167420
Resolves #165581
Screen.Recording.2023-09-27.at.17.21.34.mov