Skip to content

Fix some type issues in x-pack/test_serverless #167346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delanni merged 6 commits into from
Sep 27, 2023
Merged

Fix some type issues in x-pack/test_serverless #167346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
771043c
Pick x-pack/test_serverless from #166813
Ikuni17 Sep 26, 2023
925f29d
Apply suggestions from code review
delanni Sep 27, 2023
508659c
Merge branch 'main' into fix/x-pack-test-serverless-types
delanni Sep 27, 2023
9cd04ce
Merge branch 'main' into fix/x-pack-test-serverless-types
Sep 27, 2023
0acf688
Merge branch 'main' into fix/x-pack-test-serverless-types
Sep 27, 2023
d66f3fc
Merge branch 'main' into fix/x-pack-test-serverless-types
kibanamachine Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions x-pack/test_serverless/api_integration/services/svl_cases/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ import { CasesFindResponse } from '@kbn/cases-plugin/common/types/api';
import { kbnTestConfig, kibanaTestSuperuserServerless } from '@kbn/test';
import { FtrProviderContext } from '../../ftr_provider_context';

export interface User {
username: string;
password: string;
description?: string;
roles: string[];
}
Comment on lines +17 to +22
Copy link
Contributor

@watson watson Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see that User is used outside of this file?

Copy link
Contributor

@delanni delanni Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still verifying these, but I these kinds of "export" additions were a kind of typescript errors that were something like an inferred type was private - these additions fixed those errors, but now that I'm re-verifying, both User and CommonSavedObjectAttributes works without export, so I'm puzzled 😕

Copy link
Contributor

@watson watson Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE TypeScript errors work in mysterious ways 🤷

Copy link
Contributor

@delanni delanni Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't an IDE, it was through the typecheck command. But it no longer seems to be present, so we can undo these, or keep them


export function SvlCasesApiServiceProvider({ getService }: FtrProviderContext) {
const kbnServer = getService('kibanaServer');
const supertest = getService('supertest');

interface User {
username: string;
password: string;
description?: string;
roles: string[];
}

const superUser: User = {
username: 'superuser',
password: 'superuser',
Expand Down
16 changes: 8 additions & 8 deletions x-pack/test_serverless/api_integration/services/svl_cases/omit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ import { Case, Attachment } from '@kbn/cases-plugin/common/types/domain';
import { omit } from 'lodash';
import { FtrProviderContext } from '../../ftr_provider_context';

export function SvlCasesOmitServiceProvider({}: FtrProviderContext) {
interface CommonSavedObjectAttributes {
id?: string | null;
created_at?: string | null;
updated_at?: string | null;
version?: string | null;
[key: string]: unknown;
}
export interface CommonSavedObjectAttributes {
id?: string | null;
created_at?: string | null;
updated_at?: string | null;
version?: string | null;
[key: string]: unknown;
}
Comment on lines +12 to +18
Copy link
Contributor

@watson watson Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see that CommonSavedObjectAttributes is used outside of this file?


export function SvlCasesOmitServiceProvider({}: FtrProviderContext) {
const savedObjectCommonAttributes = ['created_at', 'updated_at', 'version', 'id'];

return {
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test_serverless/functional/test_suites/observability/cypress/support/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ Cypress.Commands.add('loginAsElasticUser', () => {
method: 'POST',
url: `${kibanaUrlWithoutAuth}/internal/security/login`,
body: {
providerType: basicProvider.type,
providerName: basicProvider.name,
providerType: basicProvider?.type,
providerName: basicProvider?.name,
currentURL: `${kibanaUrlWithoutAuth}/login`,
params: { username, password },
},
Expand Down