Skip to content

[ML] AIOps: Enable event_generating_elements_should_be_instrumented eslint rule.#167317

Merged
walterra merged 1 commit intoelastic:mainfrom
walterra:ml-aiops-eslint-data-test-subj-telemetry
Sep 28, 2023
Merged

[ML] AIOps: Enable event_generating_elements_should_be_instrumented eslint rule.#167317
walterra merged 1 commit intoelastic:mainfrom
walterra:ml-aiops-eslint-data-test-subj-telemetry

Conversation

@walterra
Copy link
Copy Markdown
Contributor

@walterra walterra commented Sep 26, 2023

Summary

Implements #153108.

This enables the @kbn/telemetry/event_generating_elements_should_be_instrumented eslint rule for the aiops plugin to enforce data-test-subj attributes on actionable EUI components so they are auto-instrumented by telemetry.

The ids were first auto-created using node scripts/eslint --fix x-pack/plugins/aiops and then adapted.


@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.11.0 labels Sep 26, 2023
@walterra walterra self-assigned this Sep 26, 2023
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 593.8KB 594.5KB +707.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra marked this pull request as ready for review September 27, 2023 15:50
@walterra walterra requested a review from a team as a code owner September 27, 2023 15:50
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Copy Markdown
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit adc9ab9 into elastic:main Sep 28, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants