[ML] Changes wording of awaiting ML nodes messages#167306
Merged
jgowdyelastic merged 6 commits intoelastic:mainfrom Sep 27, 2023
Merged
[ML] Changes wording of awaiting ML nodes messages#167306jgowdyelastic merged 6 commits intoelastic:mainfrom
jgowdyelastic merged 6 commits intoelastic:mainfrom
Conversation
jgowdyelastic
requested review from
droberts195,
peteharverson and
szabosteve
jgowdyelastic
added
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
| <FormattedMessage | ||
| id="xpack.ml.jobsAwaitingNodeWarning.noMLNodesAvailableDescription" | ||
| defaultMessage="There {jobCount, plural, one {is} other {are}} {jobCount, plural, one {# job} other {# jobs}} waiting for machine learning nodes to start." | ||
| defaultMessage="There {jobCount, plural, one {is} other {are}} {jobCount, plural, one {# job} other {# jobs}} waiting for autoscaling to add ML capacity. Please wait up to 5 minutes for this to happen." |
Contributor
There was a problem hiding this comment.
@droberts195 can we guarantee that this will happen within 5 minutes? Is it safer to remove the second sentence altogether?
There was a problem hiding this comment.
No, it's not guaranteed. On classic Cloud the poll of the autoscaling API is every 5 minutes, and then there's the time taken for a plan change after that, so if you're unlucky it could be 10 minutes. Serverless should react much faster.
I think it's good to give some idea of timing. Maybe, "This may take several minutes." for the second sentence?
Contributor
There was a problem hiding this comment.
This may take several minutes. for the second sentence sounds good to me.
szabosteve
reviewed
Sep 27, 2023
...s/ml/public/application/components/jobs_awaiting_node_warning/jobs_awaiting_node_warning.tsx
Outdated
Show resolved
Hide resolved
...nts/jobs_awaiting_node_warning/new_job_awaiting_node_shared/new_job_awaiting_node_shared.tsx
Outdated
Show resolved
Hide resolved
…node_warning/jobs_awaiting_node_warning.tsx Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
…node_warning/new_job_awaiting_node_shared/new_job_awaiting_node_shared.tsx Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
deleted the
changing-wording-of-awaiting-ml-nodes-messages
branch
szabosteve
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the text for the info callouts which are displayed when anomaly detection jobs are waiting for a node.
@szabosteve would you mind having a review of the text?
Jobs list
Creating a new job
Fixes #165472