[Fleet] Add retries w/ backoff to Fleet setup on Kibana boot#167246
Merged
joshdover merged 10 commits intoelastic:mainfrom Sep 28, 2023
Merged
[Fleet] Add retries w/ backoff to Fleet setup on Kibana boot#167246joshdover merged 10 commits intoelastic:mainfrom
joshdover merged 10 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
joshdover
commented
Sep 26, 2023
| "email-addresses": "^5.0.0", | ||
| "execa": "^4.0.2", | ||
| "expiry-js": "0.1.7", | ||
| "exponential-backoff": "^3.1.1", |
Contributor
Author
There was a problem hiding this comment.
Kibana already has this dependency as a transitive dep, thought it made sense to just use it again here.
…-ref HEAD~1..HEAD --fix'
Contributor
|
Changed the keyword in the description to |
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
pgayvallet
approved these changes
Sep 28, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #165971
This adds retry logic w/ backoff to Fleet's setup process that runs on Kibana boot. For now, this is behind a
xpack.fleet.internal.retrySetupOnBootfeature flag that is only enabled on Serverless projects.In ESS, we depend on the Integrations Server's boot process to implicitly perform the retry logic, since it depends on Fleet setup to be completed before it can successfully boot. This behavior does not exist on Serverless so we need built-in logic to perform this. The objects that are setup on serverless are:
This change does not block Kibana startup, so that Kibana can still be used while Fleet's setup process is retrying to completion. Fleet will report the current status of it's setup on the Kibana-wide
/api/statusAPI, including the number of retry attempts and the last error encountered.This change does not include any explicit tests, but instead is relying on the existing test coverage of Serverless end-to-end tests, Fleet setup FTR tests, and the
exponential-backofflibrary's unit tests.Checklist
Delete any items that are not applicable to this PR.