[ML] Move chi2test to package#167237
Merged
walterra merged 12 commits intoelastic:mainfrom Sep 27, 2023
Merged
Conversation
walterra
added
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
force-pushed
the
ml-chi2test-package
branch
from
d9edeee to
4e15d9e
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
peteharverson
approved these changes
Sep 27, 2023
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. I gave the data comparison a test and all looks good.
qn895
approved these changes
Sep 27, 2023
Member
|
LGTM 🎉 |
This was referenced Sep 28, 2023
Merged
walterra
added a commit
that referenced
this pull request
Sep 28, 2023
…ailable via `server` (#167465) Follow up to #167237. Part of #167467. We plan to reuse some of the queries log pattern analysis does to use via log rate analysis too. Log pattern analysis mostly does queries from the client side, late rate analysis has its own API endpoint and does ES queries via Kibana server. In preparation for the use via log rate analysis, this moves the code we need to have available server side for log rate analysis to the `common` area of the plugin so it can be used both on server/client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
chi2testutils so fare were only used within data comparison view. We plan to use it with other plugins, so moving it so a separate package in this PR.SIGNIFICANCE_LEVELSwas updated to include some more digits.Checklist