Merged
Conversation
Limit diff to just the files contained in the PR
delanni
approved these changes
Sep 26, 2023
Contributor
Author
|
Merged ahead of complete CI run due to this impacting a lot of developers. The modified CI steps did complete before merging |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @watson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
.buildkite/scripts/steps/check_types_commits.shscript (introduced in #167060) is comparing the latest commit of the PR against the target branch (usuallymain). But if the PR is not fully up to date with the target branch, the diff is also going to contain any changes that has landed in the target branch since the PR was branched off. This is going to include a lot of extratsconfig.jsonfiles not related to the PR and will make solving the TypeScript errors a lot harder for the PR author.Solution
Limit diff to just the files contained in the PR by finding the closest common ancestor between the target branch and the current
HEAD.(This PR also makes the
.buildkite/scripts/steps/check_types_commits.shfile executable.)