Switch Check Types to Commit Diff for on merge pipeline#167206
Merged
Ikuni17 merged 1 commit intoelastic:mainfrom Sep 26, 2023
Merged
Switch Check Types to Commit Diff for on merge pipeline#167206Ikuni17 merged 1 commit intoelastic:mainfrom
Ikuni17 merged 1 commit intoelastic:mainfrom
Conversation
Ikuni17
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @Ikuni17 |
delanni
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After merging #167060,
Check Typesis going to fail in the on merge pipeline until all type errors are triaged. For now, lets use the commit diff type check.