[Asset Manager] Creates baseline public asset client for use in public plugins

[jasonrhodes]

Closes #167075

Summary

Adds a public asset client available in the setup lifecycle hook for plugins that depend on this one. getHosts is the only method available on this client for now.

TODO, before merge:

• Add docs for the server client
• Add docs for the public client
• Remove REST docs from plugin docs, not needed
• Add unit tests for public client

Testing this PR

One way of testing this new client is to apply the attached test-assets.patch file locally, adjust the date range in the getHosts query that is added in the infra plugin, and then start Kibana and navigate to the infra app. You should see print out in the browser console.

test-assets.patch

[ghost]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[jbudz]

limits.yml

[klacabane]

The original config.ts test was split in two configurations, one for testing apis with assets source and the other for signals. Currently the signals test suite is enabled

[jasonrhodes]

Oh ok good call out, I'll take a look and maybe adjust slightly in my next PR

[klacabane]

can the packages import types from assetmanager plugin instead ?

[jasonrhodes]

Should packages import from plugins? That sounds wrong, but maybe it's allowed for types only? Not sure it's a good idea...

[klacabane]

packages already do that (eg kbn-data-service, alert_details..) but I don't know if that's recommended

[jasonrhodes]

Ok, I'll try to poke around and think on that a bit.

[klacabane]

LGTM

[jasonrhodes]

This recently merged PR is going to cause conflicts for this PR -- I'll fix.

[neptunian]

I think there is an issue with public access to the config. I can't seem to enable the public plugin because my config isn't being read.

[legrego]

Change to test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM

[jrodewig]

@kibanamachine run elasticsearch-ci/docs

[jasonrhodes]

@kibanamachine run elasticsearch-ci/docs

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 97c88db

Failed CI Steps

• FTR Configs #36

Test Failures

• [job] [logs] FTR Configs #36 / serverless security UI Case View page "before all" hook for "should show the case view page correctly"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
assetManager	-	6	+6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
assetManager	2	9	+7

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
assetManager	0	2	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
assetManager	-	2.2KB	+2.2KB

Unknown metric groups

API count

id	before	after	diff
assetManager	2	9	+7

History

• 💔 Build #163680 failed e402d28
• 💔 Build #163645 failed 167f69c
• 💔 Build #163547 failed c1efc0a
• 💚 Build #163116 succeeded a56171a
• 💔 Build #162642 failed 759b999670e8ddc588b8f97e101818ee93882727

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream