feat(slo): limit perPage in find api#167185
Merged
kdelemme merged 2 commits intoelastic:mainfrom Sep 28, 2023
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
release_note:skip
Contributor
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: cc @kdelemme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #166768
Summary
This PR fixes the find SLO api by limiting the maximum allowed perPage query parameter to 5000.
Previously providing a perPage value greater than 5000 was producing an ES error which was caught and handled in a way that no response was returned from the API.