Skip to content

[Cloud] ES endpoint discovery#167122

Merged
sebelga merged 32 commits intoelastic:mainfrom
sebelga:es-endpoint-discovery
Sep 28, 2023
Merged

[Cloud] ES endpoint discovery#167122
sebelga merged 32 commits intoelastic:mainfrom
sebelga:es-endpoint-discovery

Conversation

@sebelga
Copy link
Contributor

@sebelga sebelga commented Sep 25, 2023

In this PR I've added a new "Endpoints" item in the top bar Help menu (only in Cloud).

Implementation

As the deployment details is consumed in 2 places (fleet "Integrations" and help menu), I've created a package to expose the UI component.
I set the ownership of the package to the team that owns the "cloud_integrations" plugin (the core team).
Let me know if this should be changed.

How to test

  • Add the following in kibana.yml
xpack.cloud.id: "ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM="
  • Modify the maybe_add_cloud_links file
--- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts
+++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts
@@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud, share }: MaybeAddClo
   const userObservable = defer(() => security.authc.getCurrentUser()).pipe(
     // Check if user is a cloud user.
     map((user) => user.elastic_cloud_user),
+    map(() => true),
     // If user is not defined due to an unexpected error, then fail *open*.
     catchError(() => of(true)),
     filter((isElasticCloudUser) => isElasticCloudUser === true),
  • Launch Kibana and open the "help" menu: check that the modal is correct
  • Navigate to "Integrations" and check that the "Endpoints" popover is correct

Screenshots

Screenshot 2023-09-25 at 12 36 44 Screenshot 2023-09-25 at 12 37 01 Screenshot 2023-09-25 at 12 37 36

Fixes #165019

@github-actions
Copy link
Contributor

Documentation preview:

@sebelga sebelga changed the title [Cloud] ES endpoint disovery [Cloud] ES endpoint discovery Sep 25, 2023
@sebelga
Copy link
Contributor Author

sebelga commented Sep 25, 2023

@elasticmachine merge upstream

@sebelga
Copy link
Contributor Author

sebelga commented Sep 25, 2023

@elasticmachine merge upstream

@sebelga sebelga self-assigned this Sep 26, 2023
@sebelga sebelga added the Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// label Sep 26, 2023
@sebelga
Copy link
Contributor Author

sebelga commented Sep 26, 2023

@elasticmachine merge upstream

@sebelga sebelga marked this pull request as ready for review September 27, 2023 09:11
@sebelga sebelga requested review from a team as code owners September 27, 2023 09:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Sep 27, 2023
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@vadimkibana vadimkibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Optional nits in comments. I haven't ran this locally.

@sebelga
Copy link
Contributor Author

sebelga commented Sep 27, 2023

Thanks for the review @vadimkibana ! 👍

@nchaulet nchaulet self-requested a review September 27, 2023 13:20
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM 🚀

@sebelga
Copy link
Contributor Author

sebelga commented Sep 27, 2023

Thanks for the review @pgayvallet and @nchaulet !

@sebelga sebelga enabled auto-merge (squash) September 28, 2023 07:43
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #30 / Journey[many_fields_lens_editor] Open existing Lens visualization

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudLinks 22 43 +21
fleet 951 956 +5
total +26

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-chrome-browser 68 70 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudLinks 8.9KB 14.6KB +5.7KB
core 367.5KB 367.7KB +234.0B
total +5.9KB
Unknown metric groups

API count

id before after diff
@kbn/core-chrome-browser 170 172 +2

ESLint disabled line counts

id before after diff
@kbn/cloud - 1 +1

Total ESLint disabled count

id before after diff
@kbn/cloud - 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

@sebelga sebelga merged commit 92a92ff into elastic:main Sep 28, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Sep 28, 2023
@sebelga sebelga deleted the es-endpoint-discovery branch September 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elasticsearch Endpoint Should Be More Discoverable in Kibana

7 participants