[Cloud] ES endpoint discovery#167122
Conversation
|
Documentation preview: |
…o es-endpoint-discovery
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
Pinging @elastic/fleet (Team:Fleet) |
vadimkibana
left a comment
There was a problem hiding this comment.
Code changes LGTM. Optional nits in comments. I haven't ran this locally.
|
Thanks for the review @vadimkibana ! 👍 |
|
Thanks for the review @pgayvallet and @nchaulet ! |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @sebelga |
In this PR I've added a new "Endpoints" item in the top bar Help menu (only in Cloud).
Implementation
As the deployment details is consumed in 2 places (fleet "Integrations" and help menu), I've created a package to expose the UI component.
I set the ownership of the package to the team that owns the "cloud_integrations" plugin (the
coreteam).Let me know if this should be changed.
How to test
kibana.ymlmaybe_add_cloud_linksfileScreenshots
Fixes #165019