[Index management] Data stream edit data retention

packages/kbn-doc-links/src/get_doc_links.ts

@@ -413,6 +413,7 @@ export const getDocLinks = ({ kibanaBranch }: GetDocLinkOptions): DocLinks => {
       secureCluster: `${ELASTICSEARCH_DOCS}secure-cluster.html`,
       shardAllocationSettings: `${ELASTICSEARCH_DOCS}modules-cluster.html#cluster-shard-allocation-settings`,
       sortSearch: `${ELASTICSEARCH_DOCS}sort-search-results.html`,
+      tutorialUpdateExistingDataStream: `${ELASTICSEARCH_DOCS}tutorial-manage-existing-data-stream.html`,
       transportSettings: `${ELASTICSEARCH_DOCS}modules-network.html#common-network-settings`,
       typesRemoval: `${ELASTICSEARCH_DOCS}removal-of-types.html`,
       setupUpgrade: `${ELASTICSEARCH_DOCS}setup-upgrade.html`,

x-pack/plugins/index_management/__jest__/client_integration/helpers/http_requests.ts

@@ -90,6 +90,18 @@ const registerHttpRequestMockHelpers = (
   const setDeleteDataStreamResponse = (response?: HttpResponse, error?: ResponseError) =>
     mockResponse('POST', `${API_BASE_PATH}/delete_data_streams`, response, error);
 
+  const setEditDataRetentionResponse = (
+    dataStreamId: string,
+    response?: HttpResponse,
+    error?: ResponseError
+  ) =>
+    mockResponse(
+      'PUT',
+      `${API_BASE_PATH}/data_streams/${encodeURIComponent(dataStreamId)}/data_retention`,
+      response,
+      error
+    );
+
   const setDeleteTemplateResponse = (response?: HttpResponse, error?: ResponseError) =>
     mockResponse('POST', `${API_BASE_PATH}/delete_index_templates`, response, error);
 
@@ -196,6 +208,7 @@ const registerHttpRequestMockHelpers = (
     setLoadDataStreamResponse,
     setDeleteDataStreamResponse,
     setDeleteTemplateResponse,
+    setEditDataRetentionResponse,
     setLoadTemplateResponse,
     setCreateTemplateResponse,
     setLoadIndexSettingsResponse,

x-pack/plugins/index_management/__jest__/client_integration/helpers/test_subjects.ts

@@ -92,5 +92,14 @@ export type TestSubjects =
   | 'createAndExecuteButton'
   | 'enrichPolicySummaryList'
   | 'requestBody'
+  | 'editDataRetentionButton'
   | 'errorWhenCreatingCallout'
+  | 'manageDataStreamButton'
+  | 'dataRetentionValue'
+  | 'policyNameField'
+  | 'configuredByILMWarning'
+  | 'show-filters-button'
+  | 'filter-option-h'
+  | 'infiniteRetentionPeriod.input'
+  | 'saveButton'
   | 'createIndexSaveButton';

x-pack/plugins/index_management/__jest__/client_integration/home/data_streams_tab.helpers.ts

@@ -34,6 +34,7 @@ export interface DataStreamsTabTestBed extends TestBed<TestSubjects> {
     selectDataStream: (name: string, selected: boolean) => void;
     clickConfirmDelete: () => void;
     clickDeleteDataStreamButton: () => void;
+    clickEditDataRetentionButton: () => void;
     clickDetailPanelIndexTemplateLink: () => void;
   };
   findDeleteActionAt: (index: number) => ReactWrapper;
@@ -176,8 +177,13 @@ export const setup = async (
   };
 
   const clickDeleteDataStreamButton = () => {
-    const { find } = testBed;
-    find('deleteDataStreamButton').simulate('click');
+    testBed.find('manageDataStreamButton').simulate('click');
+    testBed.find('deleteDataStreamButton').simulate('click');
+  };
+
+  const clickEditDataRetentionButton = () => {
+    testBed.find('manageDataStreamButton').simulate('click');
+    testBed.find('editDataRetentionButton').simulate('click');
   };
 
   const clickDetailPanelIndexTemplateLink = async () => {
@@ -236,6 +242,7 @@ export const setup = async (
       selectDataStream,
       clickConfirmDelete,
       clickDeleteDataStreamButton,
+      clickEditDataRetentionButton,
       clickDetailPanelIndexTemplateLink,
     },
     findDeleteActionAt,
@@ -267,6 +274,7 @@ export const createDataStreamPayload = (dataStream: Partial<DataStream>): DataSt
   maxTimeStamp: 420,
   privileges: {
     delete_index: true,
+    manage_data_stream_lifecycle: true,
   },
   hidden: false,
   lifecycle: {

x-pack/plugins/index_management/__jest__/client_integration/home/data_streams_tab.test.ts

@@ -7,6 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { createMemoryHistory } from 'history';
+import { notificationServiceMock } from '@kbn/core/public/mocks';
 
 import {
   breadcrumbService,
@@ -15,6 +16,7 @@ import {
 import { API_BASE_PATH } from '../../../common/constants';
 import * as fixtures from '../../../test/fixtures';
 import { setupEnvironment } from '../helpers';
+import { notificationService } from '../../../public/application/services/notification';
 
 import {
   DataStreamsTabTestBed,
@@ -134,6 +136,8 @@ describe('Data Streams tab', () => {
   });
 
   describe('when there are data streams', () => {
+    const notificationsServiceMock = notificationServiceMock.createStartContract();
+
     beforeEach(async () => {
       const {
         setLoadIndicesResponse,
@@ -169,7 +173,13 @@ describe('Data Streams tab', () => {
       setLoadTemplatesResponse({ templates: [indexTemplate], legacyTemplates: [] });
       setLoadTemplateResponse(indexTemplate.name, indexTemplate);
 
-      testBed = await setup(httpSetup, { history: createMemoryHistory() });
+      notificationService.setup(notificationsServiceMock);
+      testBed = await setup(httpSetup, {
+        history: createMemoryHistory(),
+        services: {
+          notificationService,
+        },
+      });
       await act(async () => {
         testBed.actions.goToDataStreamsList();
       });
@@ -327,6 +337,64 @@ describe('Data Streams tab', () => {
         );
       });
 
+      describe('update data retention', () => {
+        test('can set data retention period', async () => {
+          const {
+            actions: { clickNameAt, clickEditDataRetentionButton },
+          } = testBed;
+
+          await clickNameAt(0);
+
+          clickEditDataRetentionButton();
+
+          httpRequestsMockHelpers.setEditDataRetentionResponse('dataStream1', {
+            success: true,
+          });
+
+          // set data retention value
+          testBed.form.setInputValue('dataRetentionValue', '7');
+          // Set data retention unit
+          testBed.find('show-filters-button').simulate('click');
+          testBed.find('filter-option-h').simulate('click');
+
+          await act(async () => {
+            testBed.find('saveButton').simulate('click');
+          });
+          testBed.component.update();
+
+          expect(httpSetup.put).toHaveBeenLastCalledWith(
+            `${API_BASE_PATH}/data_streams/dataStream1/data_retention`,
+            expect.objectContaining({ body: JSON.stringify({ dataRetention: '7h' }) })
+          );
+        });
+
+        test('allows to set infinite retention period', async () => {
+          const {
+            actions: { clickNameAt, clickEditDataRetentionButton },
+          } = testBed;
+
+          await clickNameAt(0);
+
+          clickEditDataRetentionButton();
+
+          httpRequestsMockHelpers.setEditDataRetentionResponse('dataStream1', {
+            success: true,
+          });
+
+          testBed.form.toggleEuiSwitch('infiniteRetentionPeriod.input');
+
+          await act(async () => {
+            testBed.find('saveButton').simulate('click');
+          });
+          testBed.component.update();
+
+          expect(httpSetup.put).toHaveBeenLastCalledWith(
+            `${API_BASE_PATH}/data_streams/dataStream1/data_retention`,
+            expect.objectContaining({ body: JSON.stringify({}) })
+          );
+        });
+      });
+
       test('clicking index template name navigates to the index template details', async () => {
         const {
           actions: { clickNameAt, clickDetailPanelIndexTemplateLink },
@@ -423,6 +491,33 @@ describe('Data Streams tab', () => {
       expect(findDetailPanelIlmPolicyLink().prop('href')).toBe('/test/my_ilm_policy');
     });
 
+    test('with ILM updating data retention should be disabled', async () => {
+      const { setLoadDataStreamsResponse, setLoadDataStreamResponse } = httpRequestsMockHelpers;
+
+      const dataStreamForDetailPanel = createDataStreamPayload({
+        name: 'dataStream1',
+        ilmPolicyName: 'my_ilm_policy',
+      });
+
+      setLoadDataStreamsResponse([dataStreamForDetailPanel]);
+      setLoadDataStreamResponse(dataStreamForDetailPanel.name, dataStreamForDetailPanel);
+
+      testBed = await setup(httpSetup, {
+        history: createMemoryHistory(),
+        url: urlServiceMock,
+      });
+      await act(async () => {
+        testBed.actions.goToDataStreamsList();
+      });
+      testBed.component.update();
+
+      const { actions } = testBed;
+      await actions.clickNameAt(0);
+
+      testBed.find('manageDataStreamButton').simulate('click');
+      expect(testBed.find('editDataRetentionButton').exists()).toBeFalsy();
+    });
+
     test('with an ILM url locator and no ILM policy', async () => {
       const { setLoadDataStreamsResponse, setLoadDataStreamResponse } = httpRequestsMockHelpers;
 
@@ -567,15 +662,29 @@ describe('Data Streams tab', () => {
 
       const dataStreamWithDelete = createDataStreamPayload({
         name: 'dataStreamWithDelete',
-        privileges: { delete_index: true },
+        privileges: { delete_index: true, manage_data_stream_lifecycle: true },
       });
       const dataStreamNoDelete = createDataStreamPayload({
         name: 'dataStreamNoDelete',
-        privileges: { delete_index: false },
+        privileges: { delete_index: false, manage_data_stream_lifecycle: true },
+      });
+      const dataStreamNoEditRetention = createDataStreamPayload({
+        name: 'dataStreamNoEditRetention',
+        privileges: { delete_index: true, manage_data_stream_lifecycle: false },
+      });
+
+      const dataStreamNoPermissions = createDataStreamPayload({
+        name: 'dataStreamNoPermissions',
+        privileges: { delete_index: false, manage_data_stream_lifecycle: false },
       });
 
       beforeEach(async () => {
-        setLoadDataStreamsResponse([dataStreamWithDelete, dataStreamNoDelete]);
+        setLoadDataStreamsResponse([
+          dataStreamWithDelete,
+          dataStreamNoDelete,
+          dataStreamNoEditRetention,
+          dataStreamNoPermissions,
+        ]);
 
         testBed = await setup(httpSetup, { history: createMemoryHistory(), url: urlServiceMock });
         await act(async () => {
@@ -590,6 +699,8 @@ describe('Data Streams tab', () => {
 
         expect(tableCellsValues).toEqual([
           ['', 'dataStreamNoDelete', 'green', '1', '7d', ''],
+          ['', 'dataStreamNoEditRetention', 'green', '1', '7d', 'Delete'],
+          ['', 'dataStreamNoPermissions', 'green', '1', '7d', ''],
           ['', 'dataStreamWithDelete', 'green', '1', '7d', 'Delete'],
         ]);
       });
@@ -610,26 +721,51 @@ describe('Data Streams tab', () => {
         expect(find('deleteDataStreamsButton').exists()).toBeTruthy();
       });
 
-      test('displays delete button in detail panel', async () => {
+      test('hides delete button in detail panel', async () => {
         const {
           actions: { clickNameAt },
           find,
         } = testBed;
-        setLoadDataStreamResponse(dataStreamWithDelete.name, dataStreamWithDelete);
+        setLoadDataStreamResponse(dataStreamNoDelete.name, dataStreamNoDelete);
+        await clickNameAt(0);
+
+        testBed.find('manageDataStreamButton').simulate('click');
+        expect(find('deleteDataStreamButton').exists()).toBeFalsy();
+      });
+
+      test('hides edit data retention button if no permissions', async () => {
+        const {
+          actions: { clickNameAt },
+          find,
+        } = testBed;
+        setLoadDataStreamResponse(dataStreamNoEditRetention.name, dataStreamNoEditRetention);
         await clickNameAt(1);
 
-        expect(find('deleteDataStreamButton').exists()).toBeTruthy();
+        testBed.find('manageDataStreamButton').simulate('click');
+        expect(find('editDataRetentionButton').exists()).toBeFalsy();
       });
 
-      test('hides delete button in detail panel', async () => {
+      test('hides manage button if no permissions', async () => {
         const {
           actions: { clickNameAt },
           find,
         } = testBed;
-        setLoadDataStreamResponse(dataStreamNoDelete.name, dataStreamNoDelete);
-        await clickNameAt(0);
+        setLoadDataStreamResponse(dataStreamNoPermissions.name, dataStreamNoPermissions);
+        await clickNameAt(2);
 
-        expect(find('deleteDataStreamButton').exists()).toBeFalsy();
+        expect(find('manageDataStreamButton').exists()).toBeFalsy();
+      });
+
+      test('displays delete button in detail panel', async () => {
+        const {
+          actions: { clickNameAt },
+          find,
+        } = testBed;
+        setLoadDataStreamResponse(dataStreamWithDelete.name, dataStreamWithDelete);
+        await clickNameAt(3);
+
+        testBed.find('manageDataStreamButton').simulate('click');
+        expect(find('deleteDataStreamButton').exists()).toBeTruthy();
       });
     });
   });

x-pack/plugins/index_management/common/index.ts

@@ -10,6 +10,6 @@
 
 export { API_BASE_PATH, INTERNAL_API_BASE_PATH, BASE_PATH, MAJOR_VERSION } from './constants';
 
-export { getTemplateParameter } from './lib';
+export { getTemplateParameter, splitSizeAndUnits } from './lib';
 
 export * from './types';

x-pack/plugins/index_management/common/lib/data_stream_serialization.test.ts

@@ -0,0 +1,15 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { splitSizeAndUnits } from './data_stream_serialization';
+
+describe('Data stream serialization', () => {
+  test('can split size and units from lifecycle string', () => {
+    expect(splitSizeAndUnits('1h')).toEqual({ size: '1', unit: 'h' });
+    expect(splitSizeAndUnits('20micron')).toEqual({ size: '20', unit: 'micron' });
+  });
+});

x-pack/plugins/index_management/common/lib/data_stream_serialization.ts

@@ -54,3 +54,19 @@ export function deserializeDataStreamList(
 ): DataStream[] {
   return dataStreamsFromEs.map((dataStream) => deserializeDataStream(dataStream));
 }
+
+export const splitSizeAndUnits = (field: string): { size: string; unit: string } => {
+  let size = '';
+  let unit = '';
+
+  const result = /(\d+)(\w+)/.exec(field);
+  if (result) {
+    size = result[1];
+    unit = result[2];
+  }
+
+  return {
+    size,
+    unit,
+  };
+};

x-pack/plugins/index_management/common/lib/index.ts

@@ -5,7 +5,11 @@
  * 2.0.
  */
 
-export { deserializeDataStream, deserializeDataStreamList } from './data_stream_serialization';
+export {
+  deserializeDataStream,
+  deserializeDataStreamList,
+  splitSizeAndUnits,
+} from './data_stream_serialization';
 
 export {
   deserializeTemplate,