[CM] Soften response validation#166919
Merged
Dosant merged 15 commits intoelastic:mainfrom Sep 28, 2023
Merged
Conversation
sebelga
reviewed
Sep 21, 2023
packages/kbn-content-management-utils/src/saved_object_content_storage.ts
Show resolved
Hide resolved
davismcphee
reviewed
Sep 21, 2023
packages/kbn-content-management-utils/src/saved_object_content_storage.ts
Show resolved
Hide resolved
…ften-response-validation
…Dosant/kibana into d/2023-09-21-soften-response-validation
…Dosant/kibana into d/2023-09-21-soften-response-validation
…ften-response-validation # Conflicts: # src/plugins/dashboard/tsconfig.json
…ften-response-validation
3 tasks
Dosant
added
release_note:skip
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
nreese
approved these changes
Sep 27, 2023
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation and kibana-gis changes LGTM
code review only
4 tasks
drewdaemon
approved these changes
Sep 27, 2023
davismcphee
approved these changes
Sep 28, 2023
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Pulled and tested locally in Discover, and it works as expected with throwOnResultValidationError on and off. Thanks for addressing this and adding the tests! LGTM 👍
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
8 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close #167152
Log a warning instead of throwing an error in
saved_object_content_storagewhen response validation failed.We decided to do this as a precaution and as a follow up to an issue found in saved search #166886 where storage started failing because of too strict validation.
As of this PR the saved_object_content_storage covers and this change cover:
searchindex_patterndashboardlensmapsFor other types we agreed with @dej611 that instead of applying the same change for other types (visualization, graph, annotation) the team would look into migrating their types to also use
saved_object_content_storage#167421