Skip to content

Single list of rule types in observability without grouping#166772

Merged
maryam-saeidi merged 11 commits intoelastic:mainfrom
maryam-saeidi:166136-rule-type-list
Oct 2, 2023
Merged

Single list of rule types in observability without grouping#166772
maryam-saeidi merged 11 commits intoelastic:mainfrom
maryam-saeidi:166136-rule-type-list

Conversation

@maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Sep 19, 2023 •
edited
Loading

Closes #166136

Summary

This PR removes the groups in the rules list in the observability.

With disabled rule Without disabled rule
image image

🧪 How to test

  • Check the rule type list in observability > rules page
  • Check the filter works as before

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Sep 19, 2023
@maryam-saeidi maryam-saeidi self-assigned this Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi marked this pull request as ready for review September 20, 2023 13:34
@maryam-saeidi maryam-saeidi requested a review from a team September 20, 2023 13:34
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner September 20, 2023 13:34
@maryam-saeidi maryam-saeidi requested a review from a team September 20, 2023 13:34
@maryam-saeidi maryam-saeidi changed the title Add hideGrouping prop to the rule_form to use it in observability Single list of rule types in observability without grouping Sep 20, 2023
maryam-saeidi
maryam-saeidi commented Sep 20, 2023
View reviewed changes
x-pack/plugins/apm/public/components/alerting/rule_types/register_apm_rule_types.ts
}),
requiresAppContext: false,
defaultActionMessage: errorCountMessage,
priority: 80,
Copy link
Member Author

@maryam-saeidi maryam-saeidi Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This priority will be used to order the rule type list in observability. You can check the priorities assigned to each rule in the issue.

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 20, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 20, 2023

Pinging @elastic/apm-ui (Team:APM)

maryam-saeidi
maryam-saeidi commented Sep 21, 2023
View reviewed changes
x-pack/plugins/triggers_actions_ui/public/application/lib/rule_type_compare.ts
}

return ruleTypes
? ruleTypes.findIndex((frtA) => leftRuleTypesList.some((aRuleType) => aRuleType.id === frtA)) -
Copy link
Member Author

@maryam-saeidi maryam-saeidi Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit goes to @XavierM

@kdelemme kdelemme assigned kdelemme and unassigned kdelemme Sep 21, 2023
@kdelemme kdelemme self-requested a review September 21, 2023 19:49
kdelemme
kdelemme approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

image

sorenlouv
sorenlouv approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm

XavierM
XavierM reviewed Sep 26, 2023
View reviewed changes
x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_form.tsx
{ruleTypeListItemHtml}
</EuiToolTip>
)
const sortedRuleTypeNodes = hideGrouping
Copy link
Contributor

@XavierM XavierM Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we should put that under a useMemo?

Copy link
Member Author

@maryam-saeidi maryam-saeidi Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried using useMemo, but it didn't help reduce the number of calculations since this is dependent on solutions and solutions is created in useEffect every time any of the useEffects' dependencies changes, so the calculation for this also happened every time.

@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Sep 27, 2023

Seems type check error will be fixed in #167404

@kibana-ci
Copy link

kibana-ci commented Oct 1, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 562 563 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +16.0B
triggersActionsUi 1.4MB 1.4MB +437.0B
total +453.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 38.3KB 38.3KB +52.0B
infra 105.4KB 105.5KB +36.0B
observability 100.9KB 101.0KB +88.0B
total +176.0B
Unknown metric groups

API count

id before after diff
observability 571 572 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 566e086 into elastic:main Oct 2, 2023
@maryam-saeidi maryam-saeidi deleted the 166136-rule-type-list branch October 2, 2023 08:13
@kibanamachine kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Oct 2, 2023
@maryam-saeidi maryam-saeidi added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Oct 2, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 2, 2023

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XavierM XavierM XavierM approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@kdelemme kdelemme kdelemme approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Single list of rule types in observability without grouping

7 participants

@maryam-saeidi @elasticmachine @kibana-ci @XavierM @sorenlouv @kdelemme @kibanamachine