Skip to content

[Security Solution][Endpoint] Combine the Endpoint management cypress test suites into a single configuration/run#166757

Merged
paul-tavares merged 14 commits intoelastic:mainfrom
paul-tavares:task/olm-7678-combine-cypress-configs
Sep 20, 2023
Merged

[Security Solution][Endpoint] Combine the Endpoint management cypress test suites into a single configuration/run#166757
paul-tavares merged 14 commits intoelastic:mainfrom
paul-tavares:task/olm-7678-combine-cypress-configs

Conversation

@paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Sep 19, 2023

Summary

  • Combines the endpoint and mocked_data tests suites so that they run from the same cypress configuration/run buildkite setup
  • Moved test files from the endpoint/ and mocked_data/ directories into new sub-directories that more closely describe the set of tests they contain
  • The security_solution/package.json file was updated so that the following scripts will now output a warning indicating that command is no longer valid:
    • cypress:dw:endpoint
    • cypress:dw:endpoint:run
    • cypress:dw:endpoint:open

The following npm/yarn commands remain available for running tests locally:

yarn --cwd=x-pack/plugins/security_solution cypress:dw:open
yarn --cwd=x-pack/plugins/security_solution cypress:dw:run

New test file struncture:

image

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0 labels Sep 19, 2023
@paul-tavares paul-tavares self-assigned this Sep 19, 2023
…ne-cypress-configs

# Conflicts:
#	x-pack/plugins/security_solution/package.json
@paul-tavares paul-tavares marked this pull request as ready for review September 19, 2023 21:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPs changes LGTM

ELASTICSEARCH_URL: 'http://localhost:9200',
FLEET_SERVER_URL: 'https://localhost:8220',
// Username/password used for both elastic and kibana
'cypress-react-selector': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove it as we are not using cypress-react-selector, I believe

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in parallel.ts LGTM

…ne-cypress-configs

# Conflicts:
#	x-pack/plugins/security_solution/package.json
#	x-pack/plugins/security_solution/public/management/cypress/README.md
#	x-pack/plugins/security_solution/public/management/cypress/cypress_base.config.ts
#	x-pack/plugins/security_solution/public/management/cypress/tsconfig.json
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name
  • [job] [logs] FTR Configs #13 / Triggers Actions UI Example Alerts table "after each" hook for "should sort properly"
  • [job] [logs] FTR Configs #13 / Triggers Actions UI Example Alerts table "before each" hook for "should sort properly"

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 459 454 -5

Total ESLint disabled count

id before after diff
securitySolution 526 521 -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit 807856a into elastic:main Sep 20, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 20, 2023
@paul-tavares paul-tavares deleted the task/olm-7678-combine-cypress-configs branch September 20, 2023 18:38
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Sep 21, 2023
… test suites into a single configuration/run (elastic#166757)

## Summary

- Combines the `endpoint` and `mocked_data` tests suites so that they
run from the same cypress configuration/run buildkite setup
- Moved test files from the `endpoint/` and `mocked_data/` directories
into new sub-directories that more closely describe the set of tests
they contain
- The `security_solution/package.json` file was updated so that the
following `scripts` will now output a warning indicating that command is
no longer valid:
    - `cypress:dw:endpoint`
    - `cypress:dw:endpoint:run`
    - `cypress:dw:endpoint:open`


The following npm/yarn commands remain available for running tests
locally:

```shell
yarn --cwd=x-pack/plugins/security_solution cypress:dw:open
``` 

```shell
yarn --cwd=x-pack/plugins/security_solution cypress:dw:run
```


New test file struncture:

<img width="415" alt="image"
src="https://github.com/elastic/kibana/assets/56442535/0cb4bc76-b434-4219-b73e-508645201a81">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants