Skip to content

[ML] Hide Exclude frozen data tier option in Transforms creation page#166622

Merged
qn895 merged 8 commits intoelastic:mainfrom
qn895:ml-frozen-data-tier
Sep 25, 2023
Merged

[ML] Hide Exclude frozen data tier option in Transforms creation page#166622
qn895 merged 8 commits intoelastic:mainfrom
qn895:ml-frozen-data-tier

Conversation

@qn895
Copy link
Member

@qn895 qn895 commented Sep 18, 2023 •
edited
Loading

Summary

This PR hides Exclude frozen data tier option in Transforms creation page and updates the isServerless context to provide list of enabled features instead.

Screen.Recording.2023-09-18.at.08.40.43.mov

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms Transforms v8.11.0 labels Sep 18, 2023
@qn895 qn895 requested a review from a team as a code owner September 18, 2023 13:42
@qn895 qn895 self-assigned this Sep 18, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2023

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic reviewed Sep 19, 2023
View reviewed changes
x-pack/plugins/transform/public/app/mount_management_section.ts Outdated
const unmountAppCallback = renderApp(element, appDependencies, isServerless);
const enabledFeatures: TransformEnabledFeatures = {
showNodeInfo: !isServerless,
showFrozenDataTierChoice: !isServerless,
Copy link
Member

@jgowdyelastic jgowdyelastic Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed your lead with these variable names in my ML PR.
but I'm wondering about whether we actually need two separate variables for this.
Is tier info not the same as node info?
The flag is to control whether or not we mention or show any info relating to nodes, and tiers are collections of nodes.

Copy link
Member Author

@qn895 qn895 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here d5441b6 (#166622)

peteharverson
peteharverson approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (Serverless - Search and Observability, and Stateful) and LGTM

jgowdyelastic
jgowdyelastic approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Sep 22, 2023

@elasticmachine merge upstream

@qn895 qn895 enabled auto-merge (squash) September 22, 2023 15:38
@qn895
Copy link
Member Author

qn895 commented Sep 25, 2023

@elasticmachine merge upstream

@qn895
Copy link
Member Author

qn895 commented Sep 25, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Sep 25, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 400.8KB 401.1KB +285.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit 7a9a916 into elastic:main Sep 25, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 25, 2023
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 27, 2023
Merged
jgowdyelastic added a commit that referenced this pull request Sep 28, 2023
@jgowdyelastic
[Transforms] Fixing use full data button (#167404)
046718c 
Fixing bug introduced by a merge clash between
#166622 and
#166651

The `hideFrozenDataTierChoice` prop is no longer available in the
`FullTimeRangeSelector` component and so the transforms plugin needs to
set `showFrozenDataTierChoice` in the data picker context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@qn895 qn895

Labels

backport:skip This PR does not require backporting Feature:Transforms Transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qn895 @elasticmachine @kibana-ci @peteharverson @jgowdyelastic @kibanamachine