Conversation
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ThomThomson
left a comment
There was a problem hiding this comment.
Looked through the code, and followed the instructions for testing in Discover. I also did some testing in Dashboard and everything looks great.
Nice test coverage, and very clean code. Left a few very small nits. The only thing that could elevate this is some functional test coverge, but I assume we'll be adding CCS functional test coverage in the future.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Closes #166021
Closes #163381
This PR adds inspector cluster tab MVP
This PR does not:
Test setup
yarn es snapshot -E transport.port=9500 -E http.port=9201 -E path.data=../remote1elasticsearch.hosts: ["http://localhost:9201"]to kibana.dev.yml. Note createconfig/kibana.dev.ymlif one does not exist. kibana.dev.yml is not managed by git so it has to be created the first time you add values.yarn startto start kibana processelasticsearch.hostsfrom kibana.dev.ymlyarn es snapshot -E path.data=../local1kibana_sample_data*,remote1:kibana_sample_data*timestampLocal cluster (status=successful)
Remote cluster (status=successful)
Remote cluster (status=partial, failed shard)
Remote cluster (status=skipped, all shards fail)
Remote cluster (status=skipped, no remote)